From 2a19f04679b042567dd7ed9c0208eacbb63b8d26 Mon Sep 17 00:00:00 2001
From: Dan Duvall <dduvall@wikimedia.org>
Date: Wed, 23 Aug 2017 11:09:49 -0700
Subject: Define `NODE_ENV` and always define `NODE_PATH`

Summary:
Define `NODE_ENV` based on the configuration and define `NODE_PATH` when
either `npm.install` or `npm.env` are true. The latter behavior is
necessary for final stages of multi-stage builds where npm modules are
not installed but the application requires node-related environment
variables to run.

Depends on D757
Ref T174626

Rename npm module/config to node

Renamed `npm` yaml entry to `node` and `NpmConfig` to `NodeConfig`.
Since we're dealing with general node builds and configuration, this
seems to make more sense.

Test Plan:
Run `go test ./...` or `arc unit`. Run blubber against at least the
`blubber.example.yaml`.

Reviewers: thcipriani, mobrovac, mmodell, #release-engineering-team

Reviewed By: thcipriani, #release-engineering-team

Tags: #release-engineering-team

Maniphest Tasks: T174626

Differential Revision: https://phabricator.wikimedia.org/D759
---
 README.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

(limited to 'README.md')

diff --git a/README.md b/README.md
index 0da5f6a..38cdcae 100644
--- a/README.md
+++ b/README.md
@@ -14,8 +14,8 @@ running ad-hoc commands.
 base: debian:jessie
 apt:
   packages: [libjpeg, libyaml]
-npm:
-  install: true
+node:
+  dependencies: true
 runs:
   in: /srv/service
   as: runuser
@@ -39,13 +39,13 @@ variants:
 
   production:
     base: debian:jessie-slim
-    npm:
+    node:
       env: production
     artifacts:
       - from: test
         source: /srv/service
         destination: .
-    entrypoint: [npm, start]
+    entrypoint: [node, server.js]
 ```
 
 ## Variants
@@ -68,8 +68,8 @@ becomes:
 base: debian:jessie
 apt:
   packages: [libjpeg, libyaml, libjpeg-dev, libyaml-dev, chromium]
-npm:
-  install: true
+node:
+  dependencies: true
 runs:
   in: /srv/service
   as: runuser
-- 
cgit v1.2.1