summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2013-08-25 13:51:08 +0100
committerLars Wirzenius <liw@liw.fi>2013-08-25 13:51:08 +0100
commitba82e75356b37ff7e248b984ca8484c9cd6d6141 (patch)
treeaf1841d1e87c6c63bff3b1e28de44b9917e096b9
parentce2e4e11192adcfe9862a8ab4cd18dc9e6a7f339 (diff)
downloadcmdtest-ba82e75356b37ff7e248b984ca8484c9cd6d6141.tar.gz
Clean environmnet harder
-rw-r--r--NEWS8
-rwxr-xr-xyarn10
2 files changed, 10 insertions, 8 deletions
diff --git a/NEWS b/NEWS
index 2682b85..67d870f 100644
--- a/NEWS
+++ b/NEWS
@@ -7,9 +7,11 @@ Version 0.10, released UNRELEASED
---------------------------------
* Yarn now cleans the environment when it runs shell commands for the
- implementation steps. It also sets the `SRCDIR` environment variable
- to point at the root of the source tree (the directory where yarn
- was invoked from).
+ implementation steps. The PATH variable is kept from the user's
+ environment, every other variable is either removed or hardcoded to
+ a specific value. Additionally yarn sets the `SRCDIR` environment
+ variable to point at the root of the source tree (the directory
+ where yarn was invoked from).
* A new option, `--timings`, has been added to yarn to report how long
each scenario and each step took.
diff --git a/yarn b/yarn
index c13681b..3e9be0d 100755
--- a/yarn
+++ b/yarn
@@ -317,17 +317,17 @@ class YarnRunner(cliapp.Application):
'''Return a clean environment for running tests.'''
whitelisted = [
- 'TERM',
- 'USER',
- 'USERNAME',
'PATH',
- 'HOME',
- 'LOGNAME',
]
hardcoded = {
+ 'TERM': 'dumb',
'SHELL': '/bin/sh',
'LC_ALL': 'C',
+ 'USER': 'tomjon',
+ 'USERNAME': 'tomjon',
+ 'LOGNAME': 'tomjon',
+ 'HOME': '/this/path/does/not/exist',
}
env = {}