Refactor: simplify condition to return boolean

1 files changed, 4 insertions, 6 deletions

diff --git a/distixlib/plugins/import_mail_plugin.py b/distixlib/plugins/import_mail_plugin.py
index b78eaee..053973d 100644
--- a/distixlib/plugins/import_mail_plugin.py
+++ b/distixlib/plugins/import_mail_plugin.py
@@ -82,8 +82,7 @@ class ImportMailPlugin(cliapp.Plugin):
                         ticket.get_ticket_id(), msg_ids)
             return ticket_store.save_changes()
         else:
-            existing_ticket = self._is_already_imported(msg, all_tickets)
-            if existing_ticket:
+            if self._is_already_imported(msg, all_tickets):
                 return []
             else:
                 new_ticket = self._create_ticket_from_msg(repo, msg)
@@ -102,10 +101,9 @@ class ImportMailPlugin(cliapp.Plugin):
 
     def _is_already_imported(self, msg, all_tickets):
         for ticket in all_tickets:
-            for existing_msg in ticket.get_messages():
-                if self._equal_messages(existing_msg, msg):
-                    return ticket
-        return None
+            if self._contains_message(ticket, msg):
+                return True
+        return False
 
     def _find_tickets_with_mails_referenced_by_msg(
             self, all_tickets, msg, cache):