summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2016-03-25 15:25:05 +0200
committerLars Wirzenius <liw@liw.fi>2016-03-25 15:25:05 +0200
commit5b68b264d524027713109836e933621af9346acc (patch)
treed6d5a57ce4b63829a6da982d784b68e140393b54
parent81f9819b5b404cc0235cb4edfaa32fc745b944ac (diff)
downloaddistix-5b68b264d524027713109836e933621af9346acc.tar.gz
Refactor: move condition into method
-rw-r--r--distixlib/plugins/import_mail_plugin.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/distixlib/plugins/import_mail_plugin.py b/distixlib/plugins/import_mail_plugin.py
index 5d32ca2..b43d089 100644
--- a/distixlib/plugins/import_mail_plugin.py
+++ b/distixlib/plugins/import_mail_plugin.py
@@ -77,7 +77,7 @@ class ImportMailPlugin(cliapp.Plugin):
if referenced_tickets:
for ticket in referenced_tickets:
for existing_msg in ticket.get_messages():
- if existing_msg.as_string() == msg.as_string():
+ if self._equal_messages(existing_msg, msg):
break
else:
ticket.add_message(msg)
@@ -95,10 +95,13 @@ class ImportMailPlugin(cliapp.Plugin):
all_tickets.append(new_ticket)
return ticket_store.add_ticket(new_ticket)
+ def _equal_messages(self, msg1, msg2):
+ return msg1.as_string() == msg2.as_string()
+
def _is_already_imported(self, msg, all_tickets):
for ticket in all_tickets:
for existing_msg in ticket.get_messages():
- if existing_msg.as_string() == msg.as_string():
+ if self._equal_messages(existing_msg, msg):
return ticket
return None