summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2016-03-25 15:20:27 +0200
committerLars Wirzenius <liw@liw.fi>2016-03-25 15:20:27 +0200
commit91ee079e45a3c511443542f1f4df36341aac3c9b (patch)
treea3979773ba8d3d5aea81203067a3f46ebfd83787
parentba260c901379f3a6b56f8b6c989b0692366f9064 (diff)
downloaddistix-91ee079e45a3c511443542f1f4df36341aac3c9b.tar.gz
Refactor: move local function to a method
-rw-r--r--distixlib/plugins/import_mail_plugin.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/distixlib/plugins/import_mail_plugin.py b/distixlib/plugins/import_mail_plugin.py
index d75f63c..849abff 100644
--- a/distixlib/plugins/import_mail_plugin.py
+++ b/distixlib/plugins/import_mail_plugin.py
@@ -85,14 +85,7 @@ class ImportMailPlugin(cliapp.Plugin):
ticket.get_ticket_id(), msg_ids)
return ticket_store.save_changes()
else:
- def is_already_imported():
- for ticket in all_tickets:
- for existing_msg in ticket.get_messages():
- if existing_msg.as_string() == msg.as_string():
- return ticket
- return None
-
- existing_ticket = is_already_imported()
+ existing_ticket = self._is_already_imported(msg, all_tickets)
if existing_ticket:
return []
else:
@@ -102,6 +95,13 @@ class ImportMailPlugin(cliapp.Plugin):
all_tickets.append(new_ticket)
return ticket_store.add_ticket(new_ticket)
+ def _is_already_imported(self, msg, all_tickets):
+ for ticket in all_tickets:
+ for existing_msg in ticket.get_messages():
+ if existing_msg.as_string() == msg.as_string():
+ return ticket
+ return None
+
def _find_tickets_with_mails_referenced_by_msg(
self, all_tickets, msg, cache):