Simplify logic by using helper method

1 files changed, 6 insertions, 4 deletions

diff --git a/distixlib/plugins/import_mail_plugin.py b/distixlib/plugins/import_mail_plugin.py
index b43d089..b78eaee 100644
--- a/distixlib/plugins/import_mail_plugin.py
+++ b/distixlib/plugins/import_mail_plugin.py
@@ -76,10 +76,7 @@ class ImportMailPlugin(cliapp.Plugin):
         msg_ids = self._get_message_ids(msg)
         if referenced_tickets:
             for ticket in referenced_tickets:
-                for existing_msg in ticket.get_messages():
-                    if self._equal_messages(existing_msg, msg):
-                        break
-                else:
+                if not self._contains_message(ticket, msg):
                     ticket.add_message(msg)
                     cache.add_msg_ids_for_ticket_id(
                         ticket.get_ticket_id(), msg_ids)
@@ -95,6 +92,11 @@ class ImportMailPlugin(cliapp.Plugin):
                 all_tickets.append(new_ticket)
                 return ticket_store.add_ticket(new_ticket)
 
+    def _contains_message(self, ticket, msg):
+        return any(
+            self._equal_messages(existing, msg)
+            for existing in ticket.get_messages())
+
     def _equal_messages(self, msg1, msg2):
         return msg1.as_string() == msg2.as_string()