From bed3b182d619c4b78a6bf46814e4f850836cd1d6 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Fri, 7 Apr 2017 16:04:38 +0300 Subject: refactor: Make _is_already_import get context --- distixlib/plugins/import_mail_plugin.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/distixlib/plugins/import_mail_plugin.py b/distixlib/plugins/import_mail_plugin.py index 1523663..6188a48 100644 --- a/distixlib/plugins/import_mail_plugin.py +++ b/distixlib/plugins/import_mail_plugin.py @@ -138,8 +138,7 @@ class ImportMailPlugin(cliapp.Plugin): context.cache.add_msg_ids_for_ticket_id( ticket.get_ticket_id(), msg_ids) else: - if not self._is_already_imported( - context.store, msg, context.all_ticket_ids): + if not self._is_already_imported(context, msg): new_ticket = self._create_ticket_from_msg(context.repo, msg) self._set_key_value(new_ticket, key, value) context.cache.add_msg_ids_for_ticket_id( @@ -162,9 +161,9 @@ class ImportMailPlugin(cliapp.Plugin): return store.ticket_has_message_with_text( ticket_id, msg.as_string()) - def _is_already_imported(self, store, msg, all_ticket_ids): - for ticket_id in all_ticket_ids: - if self._contains_message(store, ticket_id, msg): + def _is_already_imported(self, context, msg): + for ticket_id in context.all_ticket_ids: + if self._contains_message(context.store, ticket_id, msg): return True return False -- cgit v1.2.1