From 71711b8ed729eb38dca8b89ffedcf479316f7c1e Mon Sep 17 00:00:00 2001
From: Lars Wirzenius <liw@gytha>
Date: Fri, 13 Nov 2009 19:11:04 +0200
Subject: Copy .m4a files (AAC) as is, they way .mp3 files are copied.

---
 musictomp3 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/musictomp3 b/musictomp3
index f0eb63d..08e59c8 100755
--- a/musictomp3
+++ b/musictomp3
@@ -190,7 +190,8 @@ class MusicToMp3(object):
         return filename.endswith('.flac')
 
     def needs_copying(self, filename):
-        return filename.endswith('.mp3')
+        dummy, ext = os.path.splitext(filename)
+        return ext.lower() in ['.mp3', '.m4a']
 
     def run(self):
         logging.basicConfig(filename='musictomp3.log', level=logging.DEBUG)
-- 
cgit v1.2.1


From e1cd0507964d05a49d81dd4b6f3ffce2fe5383fa Mon Sep 17 00:00:00 2001
From: Lars Wirzenius <liw@gytha>
Date: Fri, 13 Nov 2009 19:33:37 +0200
Subject: Wrote script to test flac files.

---
 test-flacs   | 26 ++++++++++++++++++++++++++
 test-flacs.1 | 25 +++++++++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100755 test-flacs
 create mode 100644 test-flacs.1

diff --git a/test-flacs b/test-flacs
new file mode 100755
index 0000000..e3b9a92
--- /dev/null
+++ b/test-flacs
@@ -0,0 +1,26 @@
+#!/usr/bin/python
+
+
+import multiprocessing
+import os
+import subprocess
+import sys
+
+
+def test_flac(filename):
+    p = subprocess.Popen(['flac', '--totally-silent', '--test', filename])
+    p.communicate()
+    return filename, p.returncode == 0
+
+def find_files(root):
+    pathnames = set()
+    for dirname, subdirs, filenames in os.walk(root):
+        for pathname in [os.path.join(dirname, x) for x in filenames]:
+            if pathname.endswith('.flac'):
+                pathnames.add(pathname)
+    return pathnames
+
+pool = multiprocessing.Pool()
+for filename, ok in pool.map(test_flac, find_files(sys.argv[1])):
+    if not ok:
+        print 'FAIL:', filename
diff --git a/test-flacs.1 b/test-flacs.1
new file mode 100644
index 0000000..aabf8ce
--- /dev/null
+++ b/test-flacs.1
@@ -0,0 +1,25 @@
+.\" Copyright (C) 2009  Lars Wirzenius
+.\"
+.\" This program is free software: you can redistribute it and/or modify
+.\" it under the terms of the GNU General Public License as published by
+.\" the Free Software Foundation, either version 3 of the License, or
+.\" (at your option) any later version.
+.\"
+.\" This program is distributed in the hope that it will be useful,
+.\" but WITHOUT ANY WARRANTY; without even the implied warranty of
+.\" MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+.\" GNU General Public License for more details.
+.\"
+.\" You should have received a copy of the GNU General Public License
+.\" along with this program.  If not, see <http://www.gnu.org/licenses/>.
+.\"
+.TH TEST-FLACS 1
+.SH NAME
+test-flacs \- check FLAC files for correctness
+.SH SYNOPSIS
+.B test-flacs
+.IR dirname ...
+.SH DESCRIPTION
+.B test-flacs
+checks that FLAC files (*.flac) are OK, using "flac --test".
+It reports the names of the files that are not OK.
-- 
cgit v1.2.1


From 2dec307b95b755231648c001a9bc3d4607378380 Mon Sep 17 00:00:00 2001
From: Lars Wirzenius <liw@gytha>
Date: Mon, 21 Dec 2009 19:15:08 +0200
Subject: Rewritten.

---
 test-flacs | 50 ++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 42 insertions(+), 8 deletions(-)

diff --git a/test-flacs b/test-flacs
index e3b9a92..3028adc 100755
--- a/test-flacs
+++ b/test-flacs
@@ -5,12 +5,20 @@ import multiprocessing
 import os
 import subprocess
 import sys
+import time
 
 
-def test_flac(filename):
-    p = subprocess.Popen(['flac', '--totally-silent', '--test', filename])
-    p.communicate()
-    return filename, p.returncode == 0
+def test_flacs(job_queue, result_queue):
+    i = 0
+    for filename in iter(job_queue.get, None):
+        p = subprocess.Popen(['flac', '--totally-silent', '--test', filename])
+        p.communicate()
+        result_queue.put((filename, p.returncode == 0))
+        i += 1
+        if i >= 10:
+            time.sleep(1)
+            i = 0
+
 
 def find_files(root):
     pathnames = set()
@@ -20,7 +28,33 @@ def find_files(root):
                 pathnames.add(pathname)
     return pathnames
 
-pool = multiprocessing.Pool()
-for filename, ok in pool.map(test_flac, find_files(sys.argv[1])):
-    if not ok:
-        print 'FAIL:', filename
+
+files = find_files(sys.argv[1])
+        
+job_queue = multiprocessing.Queue()
+result_queue = multiprocessing.Queue()
+for job in files:
+    job_queue.put(job)
+for i in range(multiprocessing.cpu_count()):
+    p = multiprocessing.Process(target=test_flacs,
+                                args=(job_queue, result_queue))
+    p.start()
+total = len(files)
+bad = list()
+for done in range(total):
+    result = result_queue.get()
+    sys.stderr.write('\r%d / %d done' % (done + 1, total))
+    sys.stderr.flush()
+    if result:
+        filename, ok = result
+        if not ok:
+            bad.append(filename)
+
+for i in range(multiprocessing.cpu_count()):
+    job_queue.put(None)
+
+sys.stderr.write('\n')
+
+for filename in bad:
+    print 'BAD:', filename
+
-- 
cgit v1.2.1