From c976ae57dc5566e610285ee6b47a32f8850c2746 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Sun, 26 Nov 2017 17:53:28 +0100 Subject: Add: log failures to find resources in apibase This helps users (me) figure out what's wrong more easily. --- ick2/apibase.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'ick2/apibase.py') diff --git a/ick2/apibase.py b/ick2/apibase.py index 361baaa..1e4fd14 100644 --- a/ick2/apibase.py +++ b/ick2/apibase.py @@ -58,8 +58,10 @@ class APIbase: try: if 'raw_uri_path' in kwargs: del kwargs['raw_uri_path'] - body = callback(**kwargs) + body = callback(**kwargs) except ick2.NotFound as e: + ick2.log.log( + 'warning', msg_text='GET Not found', kwargs=kwargs) return ick2.not_found(e) if isinstance(body, dict): return ick2.OK(body) @@ -76,7 +78,7 @@ class APIbase: try: body = callback(body) except ick2.ExistsAlready as e: - ick2.log.log('error', msg_text=str(e)) + ick2.log.log('error', msg_text=str(e), kwargs=kwargs) return ick2.conflict(str(e)) return ick2.created(body) return wrapper @@ -91,6 +93,8 @@ class APIbase: try: body = callback(body, **kwargs) except ick2.NotFound as e: + ick2.log.log( + 'warning', msg_text='PUT Not found', kwargs=kwargs) return ick2.not_found(e) except ick2.WrongPipelineStatus as e: ick2.log.log( @@ -112,6 +116,8 @@ class APIbase: del kwargs['raw_uri_path'] body = callback(**kwargs) except ick2.NotFound as e: + ick2.log.log( + 'warning', msg_text='DELETE Not found', kwargs=kwargs) return ick2.not_found(e) return ick2.OK(body) return wrapper -- cgit v1.2.1