From 8c087e41fdda5d9508b9c95ea57fbd079142633d Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Sat, 20 Feb 2016 22:10:13 +0200 Subject: imported mails --- .../cur/.this-dir-not-empty/.empty/empty-file | 0 .../new/.this-dir-not-empty/.empty/empty-file | 0 .../new/1455998994.M347744P17339Q1.exolobe1 | 124 +++++++++++++++++++++ .../new/1455998995.M536933P17339Q35.exolobe1 | 106 ++++++++++++++++++ .../new/1455998995.M78975P17339Q22.exolobe1 | 124 +++++++++++++++++++++ .../new/1455998997.M81437P17339Q63.exolobe1 | 113 +++++++++++++++++++ .../new/1455999008.M155678P17339Q189.exolobe1 | 90 +++++++++++++++ .../tmp/.this-dir-not-empty/.empty/empty-file | 0 .../829d5f9060144a30bd44cb946b0ba1c9/ticket.yaml | 4 + 9 files changed, 561 insertions(+) create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/cur/.this-dir-not-empty/.empty/empty-file create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/.this-dir-not-empty/.empty/empty-file create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998994.M347744P17339Q1.exolobe1 create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M536933P17339Q35.exolobe1 create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M78975P17339Q22.exolobe1 create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998997.M81437P17339Q63.exolobe1 create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455999008.M155678P17339Q189.exolobe1 create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/tmp/.this-dir-not-empty/.empty/empty-file create mode 100644 tickets/829d5f9060144a30bd44cb946b0ba1c9/ticket.yaml (limited to 'tickets/829d5f9060144a30bd44cb946b0ba1c9') diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/cur/.this-dir-not-empty/.empty/empty-file b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/cur/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/.this-dir-not-empty/.empty/empty-file b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998994.M347744P17339Q1.exolobe1 b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998994.M347744P17339Q1.exolobe1 new file mode 100644 index 0000000..d4b538d --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998994.M347744P17339Q1.exolobe1 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id DA854228E5 + for ; Sun, 27 Sep 2015 14:35:21 +0200 (CEST) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 3AE77CC8; + Sun, 27 Sep 2015 13:35:21 +0100 (BST) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZgBAn-0004ev-2p; Sun, 27 Sep 2015 13:35:21 +0100 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZgBAl-0004en-Jl + for ; Sun, 27 Sep 2015 13:35:19 +0100 +Received: from mailout.easymail.ca ([64.68.201.169]) + by mx0.pepperfish.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) + (Exim 4.80) (envelope-from ) + id 1ZgBAj-0008WH-B5 + for obnam-dev@obnam.org; Sun, 27 Sep 2015 13:35:19 +0100 +Received: from localhost (localhost [127.0.0.1]) + by mailout.easymail.ca (Postfix) with ESMTP id 1C109E5F5 + for ; Sun, 27 Sep 2015 08:35:07 -0400 (EDT) +X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca +X-Spam-Flag: NO +X-Spam-Score: -3.68 +X-Spam-Level: +X-Spam-Status: No, score=-3.68 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.027, + BAYES_00=-2.599, DNS_FROM_AHBL_RHSBL=0.692] +Received: from mailout.easymail.ca ([127.0.0.1]) + by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, + port 10024) with ESMTP id m8jySb3LrAFt for ; + Sun, 27 Sep 2015 08:35:06 -0400 (EDT) +Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com + [209.85.213.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by mailout.easymail.ca (Postfix) with ESMTPSA id 1387FE5D3 + for ; Sun, 27 Sep 2015 08:35:06 -0400 (EDT) +Received: by igbni9 with SMTP id ni9so34609999igb.0 + for ; Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +MIME-Version: 1.0 +X-Received: by 10.50.79.129 with SMTP id j1mr10122935igx.63.1443357305745; + Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +Received: by 10.107.183.65 with HTTP; Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +Date: Sun, 27 Sep 2015 15:35:05 +0300 +Message-ID: +From: Henri Sivonen +To: obnam-dev@obnam.org +Content-Type: text/plain; charset=UTF-8 +X-Spam-Score: -2.1 +X-Spam-Score-int: -20 +X-Spam-Bar: -- +X-Scanned-By: pepperfish.net, Sun, 27 Sep 2015 13:35:19 +0100 +X-Spam-Report: Content analysis details: (-2.1 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [64.68.201.169 listed in list.dnswl.org] + 0.5 PPF_RECEIVED_HTTP Received header mentions http + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: 0b3defc877126cf9a9969fd77535823e +Subject: Unlocking the repo from the VFS layer +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +The unreliability of the connection between my local computer running +obnam and the remote SFTP server that I'm using for backup storage is +interfering with my use of obnam to the point that I'm not doing +regular backups. + +To address this, I'm trying to patch obnam to automatically reconnect +when the SFTP layer raises an exception. + +When the previous connection dies, a lock is typically left on the +server. This means that after reconnecting, the code should also +unlock the repo. (Obviously, unconditionally unlocking defeats the +whole point of having locks in the first place. Right now, I'm trying +to get to a point where I have something that works with a single +client. To do things properly, the client should store some +randomly-generated bits in the lock file and also keep the bits in +RAM. Then upon reconnecting, if the lock file contains the same bits +that the program still has in RAM, silent unlocking is safe.) + +Looking at the code for force_lock_plugin.py, it seems that just +calling that code from the VFS layer isn't safe, since on the VFS +layer, the repo is already open from the point of view of the repo +management code but force_lock_plugin.py opens and closes the repo. + +Any advice on what I should do where my current patch says "TODO: Need +to unlock the repo here."? I.e. how should I go about unlocking the +repo from within the VFS layer when the repo layer doesn't know that +the connection dropped? + +https://github.com/hsivonen/obnam/commit/358417c1891f28b869d4700bfa6feac88f79b78b#diff-0461b95928d689323962ad6b23dd4a09R59 + +(Aside: Is it intentional that some files have a GPLv2-or-later +license header instead of a GPLv3-or-later license header?) + +-- +Henri Sivonen +hsivonen@hsivonen.fi +https://hsivonen.fi/ + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M536933P17339Q35.exolobe1 b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M536933P17339Q35.exolobe1 new file mode 100644 index 0000000..a2adce3 --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M536933P17339Q35.exolobe1 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 02C2D2BECF + for ; Wed, 30 Sep 2015 12:18:42 +0200 (CEST) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 4CE6E2C8; + Wed, 30 Sep 2015 11:18:41 +0100 (BST) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZhETB-0007or-5f; Wed, 30 Sep 2015 11:18:41 +0100 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZhET9-0007ok-8l + for ; Wed, 30 Sep 2015 11:18:39 +0100 +Received: from mailout.easymail.ca ([64.68.201.169]) + by mx0.pepperfish.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) + (Exim 4.80) (envelope-from ) + id 1ZhET6-0007mx-FK + for obnam-dev@obnam.org; Wed, 30 Sep 2015 11:18:39 +0100 +Received: from localhost (localhost [127.0.0.1]) + by mailout.easymail.ca (Postfix) with ESMTP id AB5DFE4A9 + for ; Wed, 30 Sep 2015 06:18:26 -0400 (EDT) +X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca +X-Spam-Flag: NO +X-Spam-Score: -3.68 +X-Spam-Level: +X-Spam-Status: No, score=-3.68 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.027, + BAYES_00=-2.599, DNS_FROM_AHBL_RHSBL=0.692] +Received: from mailout.easymail.ca ([127.0.0.1]) + by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, + port 10024) with ESMTP id nBfnbwRD5fVI for ; + Wed, 30 Sep 2015 06:18:26 -0400 (EDT) +Received: from mail-ig0-f181.google.com (mail-ig0-f181.google.com + [209.85.213.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by mailout.easymail.ca (Postfix) with ESMTPSA id 3428AE438 + for ; Wed, 30 Sep 2015 06:18:26 -0400 (EDT) +Received: by igxx6 with SMTP id x6so27019265igx.1 + for ; Wed, 30 Sep 2015 03:18:25 -0700 (PDT) +MIME-Version: 1.0 +X-Received: by 10.50.67.179 with SMTP id o19mr26123201igt.63.1443608305636; + Wed, 30 Sep 2015 03:18:25 -0700 (PDT) +Received: by 10.107.183.65 with HTTP; Wed, 30 Sep 2015 03:18:25 -0700 (PDT) +In-Reply-To: +References: +Date: Wed, 30 Sep 2015 13:18:25 +0300 +Message-ID: +From: Henri Sivonen +To: obnam-dev@obnam.org +Content-Type: text/plain; charset=UTF-8 +X-Spam-Score: -2.1 +X-Spam-Score-int: -20 +X-Spam-Bar: -- +X-Scanned-By: pepperfish.net, Wed, 30 Sep 2015 11:18:39 +0100 +X-Spam-Report: Content analysis details: (-2.1 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.5 PPF_RECEIVED_HTTP Received header mentions http + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [64.68.201.169 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: dad44cf097470dfea4dc038187207232 +Subject: Re: Unlocking the repo from the VFS layer +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +On Sun, Sep 27, 2015 at 3:35 PM, Henri Sivonen wrote: +> Any advice on what I should do where my current patch says "TODO: Need +> to unlock the repo here."? I.e. how should I go about unlocking the +> repo from within the VFS layer when the repo layer doesn't know that +> the connection dropped? + +Looks like I should: + 1) Make the app object available to the VFS wrapper. + 2) Reach .repo from there. + 3) Make repo objects have an unlocking method that takes the VFS as +an argument so that the wrapper can pass the delegate VFS instead of +causing a re-entrant call to the wrapper itself. + +-- +Henri Sivonen +hsivonen@hsivonen.fi +https://hsivonen.fi/ + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M78975P17339Q22.exolobe1 b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M78975P17339Q22.exolobe1 new file mode 100644 index 0000000..d4b538d --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998995.M78975P17339Q22.exolobe1 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id DA854228E5 + for ; Sun, 27 Sep 2015 14:35:21 +0200 (CEST) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 3AE77CC8; + Sun, 27 Sep 2015 13:35:21 +0100 (BST) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZgBAn-0004ev-2p; Sun, 27 Sep 2015 13:35:21 +0100 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZgBAl-0004en-Jl + for ; Sun, 27 Sep 2015 13:35:19 +0100 +Received: from mailout.easymail.ca ([64.68.201.169]) + by mx0.pepperfish.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) + (Exim 4.80) (envelope-from ) + id 1ZgBAj-0008WH-B5 + for obnam-dev@obnam.org; Sun, 27 Sep 2015 13:35:19 +0100 +Received: from localhost (localhost [127.0.0.1]) + by mailout.easymail.ca (Postfix) with ESMTP id 1C109E5F5 + for ; Sun, 27 Sep 2015 08:35:07 -0400 (EDT) +X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca +X-Spam-Flag: NO +X-Spam-Score: -3.68 +X-Spam-Level: +X-Spam-Status: No, score=-3.68 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.027, + BAYES_00=-2.599, DNS_FROM_AHBL_RHSBL=0.692] +Received: from mailout.easymail.ca ([127.0.0.1]) + by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, + port 10024) with ESMTP id m8jySb3LrAFt for ; + Sun, 27 Sep 2015 08:35:06 -0400 (EDT) +Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com + [209.85.213.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by mailout.easymail.ca (Postfix) with ESMTPSA id 1387FE5D3 + for ; Sun, 27 Sep 2015 08:35:06 -0400 (EDT) +Received: by igbni9 with SMTP id ni9so34609999igb.0 + for ; Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +MIME-Version: 1.0 +X-Received: by 10.50.79.129 with SMTP id j1mr10122935igx.63.1443357305745; + Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +Received: by 10.107.183.65 with HTTP; Sun, 27 Sep 2015 05:35:05 -0700 (PDT) +Date: Sun, 27 Sep 2015 15:35:05 +0300 +Message-ID: +From: Henri Sivonen +To: obnam-dev@obnam.org +Content-Type: text/plain; charset=UTF-8 +X-Spam-Score: -2.1 +X-Spam-Score-int: -20 +X-Spam-Bar: -- +X-Scanned-By: pepperfish.net, Sun, 27 Sep 2015 13:35:19 +0100 +X-Spam-Report: Content analysis details: (-2.1 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [64.68.201.169 listed in list.dnswl.org] + 0.5 PPF_RECEIVED_HTTP Received header mentions http + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: 0b3defc877126cf9a9969fd77535823e +Subject: Unlocking the repo from the VFS layer +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +The unreliability of the connection between my local computer running +obnam and the remote SFTP server that I'm using for backup storage is +interfering with my use of obnam to the point that I'm not doing +regular backups. + +To address this, I'm trying to patch obnam to automatically reconnect +when the SFTP layer raises an exception. + +When the previous connection dies, a lock is typically left on the +server. This means that after reconnecting, the code should also +unlock the repo. (Obviously, unconditionally unlocking defeats the +whole point of having locks in the first place. Right now, I'm trying +to get to a point where I have something that works with a single +client. To do things properly, the client should store some +randomly-generated bits in the lock file and also keep the bits in +RAM. Then upon reconnecting, if the lock file contains the same bits +that the program still has in RAM, silent unlocking is safe.) + +Looking at the code for force_lock_plugin.py, it seems that just +calling that code from the VFS layer isn't safe, since on the VFS +layer, the repo is already open from the point of view of the repo +management code but force_lock_plugin.py opens and closes the repo. + +Any advice on what I should do where my current patch says "TODO: Need +to unlock the repo here."? I.e. how should I go about unlocking the +repo from within the VFS layer when the repo layer doesn't know that +the connection dropped? + +https://github.com/hsivonen/obnam/commit/358417c1891f28b869d4700bfa6feac88f79b78b#diff-0461b95928d689323962ad6b23dd4a09R59 + +(Aside: Is it intentional that some files have a GPLv2-or-later +license header instead of a GPLv3-or-later license header?) + +-- +Henri Sivonen +hsivonen@hsivonen.fi +https://hsivonen.fi/ + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998997.M81437P17339Q63.exolobe1 b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998997.M81437P17339Q63.exolobe1 new file mode 100644 index 0000000..1e0218c --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998997.M81437P17339Q63.exolobe1 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 02F992C147 + for ; Sat, 31 Oct 2015 13:03:03 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 770ED2D8; + Sat, 31 Oct 2015 12:03:02 +0000 (GMT) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZsUsA-0006re-9N; Sat, 31 Oct 2015 12:03:02 +0000 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZsUs8-0006qp-DW + for ; Sat, 31 Oct 2015 12:03:00 +0000 +Received: from mailout.easymail.ca ([64.68.201.169]) + by mx0.pepperfish.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) + (Exim 4.80) (envelope-from ) + id 1ZsUs5-00008z-Bt + for obnam-dev@obnam.org; Sat, 31 Oct 2015 12:03:00 +0000 +Received: from localhost (localhost [127.0.0.1]) + by mailout.easymail.ca (Postfix) with ESMTP id 5FFBFE5DD + for ; Sat, 31 Oct 2015 08:02:46 -0400 (EDT) +X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca +X-Spam-Flag: NO +X-Spam-Score: -3.674 +X-Spam-Level: +X-Spam-Status: No, score=-3.674 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.033, + BAYES_00=-2.599, DNS_FROM_AHBL_RHSBL=0.692] +Received: from mailout.easymail.ca ([127.0.0.1]) + by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, + port 10024) with ESMTP id PZxILDdfJibk for ; + Sat, 31 Oct 2015 08:02:45 -0400 (EDT) +Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com + [209.85.213.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by mailout.easymail.ca (Postfix) with ESMTPSA id 096C1E59E + for ; Sat, 31 Oct 2015 08:02:45 -0400 (EDT) +Received: by igdg1 with SMTP id g1so28995013igd.1 + for ; Sat, 31 Oct 2015 05:02:44 -0700 (PDT) +MIME-Version: 1.0 +X-Received: by 10.50.7.70 with SMTP id h6mr2617873iga.63.1446292964734; Sat, + 31 Oct 2015 05:02:44 -0700 (PDT) +Received: by 10.107.19.137 with HTTP; Sat, 31 Oct 2015 05:02:44 -0700 (PDT) +In-Reply-To: <20151019191152.GJ2563@exolobe1.liw.fi> +References: + <20151019191152.GJ2563@exolobe1.liw.fi> +Date: Sat, 31 Oct 2015 14:02:44 +0200 +Message-ID: +From: Henri Sivonen +To: Lars Wirzenius +Content-Type: text/plain; charset=UTF-8 +X-Spam-Score: -2.1 +X-Spam-Score-int: -20 +X-Spam-Bar: -- +X-Scanned-By: pepperfish.net, Sat, 31 Oct 2015 12:03:00 +0000 +X-Spam-Report: Content analysis details: (-2.1 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.5 PPF_RECEIVED_HTTP Received header mentions http + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [64.68.201.169 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: e606bea56426b7460dd1a96e279d41e5 +Cc: obnam-dev@obnam.org +Subject: Re: Unlocking the repo from the VFS layer +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +On Mon, Oct 19, 2015 at 10:11 PM, Lars Wirzenius wrote: +> On Sun, Sep 27, 2015 at 03:35:05PM +0300, Henri Sivonen wrote: +>> To address this, I'm trying to patch obnam to automatically reconnect +>> when the SFTP layer raises an exception. +> +> I don't think that logic belongs in the VFS layer, or in the SFTP +> module. It's the kind of policy decision that an upper layer should +> handle. Sorry. + +Can you give a more specific hint of which layer I should be looking at? + +My thinking with putting the recovery on the VFS layer on the level of +principle is similar to how TCP makes IP seem reliable instead of +making the application worry about failures and on the practical level +it seemed harder to track down all higher-layer call sites that might +experience an exception than to mechanically wrap all methods on the +VFS layer. + +-- +Henri Sivonen +hsivonen@hsivonen.fi +https://hsivonen.fi/ + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455999008.M155678P17339Q189.exolobe1 b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455999008.M155678P17339Q189.exolobe1 new file mode 100644 index 0000000..3b1d284 --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455999008.M155678P17339Q189.exolobe1 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 40C1C2F07B + for ; Mon, 19 Oct 2015 21:12:03 +0200 (CEST) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id E6E25B3B; + Mon, 19 Oct 2015 20:12:02 +0100 (BST) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZoFqk-0001cO-Pw; Mon, 19 Oct 2015 20:12:02 +0100 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1ZoFqj-0001bi-Gr + for ; Mon, 19 Oct 2015 20:12:01 +0100 +Received: from pieni.net ([95.142.166.37] ident=postfix) + by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) + (Exim 4.80) (envelope-from ) id 1ZoFqh-00018P-On + for obnam-dev@obnam.org; Mon, 19 Oct 2015 20:12:01 +0100 +Received: from exolobe1.liw.fi (82-181-8-107.bb.dnainternet.fi [82.181.8.107]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPSA id 253C12F07B + for ; Mon, 19 Oct 2015 21:11:54 +0200 (CEST) +Received: from exolobe1.liw.fi (localhost [127.0.0.1]) + by exolobe1.liw.fi (Postfix) with ESMTPS id 718A84050E + for ; Mon, 19 Oct 2015 22:11:53 +0300 (EEST) +Date: Mon, 19 Oct 2015 22:11:52 +0300 +From: Lars Wirzenius +To: obnam-dev@obnam.org +Message-ID: <20151019191152.GJ2563@exolobe1.liw.fi> +References: +MIME-Version: 1.0 +Content-Type: text/plain; charset=iso-8859-1 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: +User-Agent: Mutt/1.5.23 (2014-03-12) +X-Spam-Score: -3.4 +X-Spam-Score-int: -33 +X-Spam-Bar: --- +X-Scanned-By: pepperfish.net, Mon, 19 Oct 2015 20:12:01 +0100 +X-Spam-Report: Content analysis details: (-3.4 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam + tool) -0.5 PPF_USER_AGENT User-Agent: exists + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: 7dc7a8a4720feec014ee0c5052b99ae1 +Subject: Re: Unlocking the repo from the VFS layer +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +On Sun, Sep 27, 2015 at 03:35:05PM +0300, Henri Sivonen wrote: +> To address this, I'm trying to patch obnam to automatically reconnect +> when the SFTP layer raises an exception. + +I don't think that logic belongs in the VFS layer, or in the SFTP +module. It's the kind of policy decision that an upper layer should +handle. Sorry. + +> (Aside: Is it intentional that some files have a GPLv2-or-later +> license header instead of a GPLv3-or-later license header?) + +Probably not. Remnants from an earlier era. But they're harmless. + +-- +Schrödinger's backup hypothesis: the condition of any backup is +undefined until a restore is attempted. -- andrewsh + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/tmp/.this-dir-not-empty/.empty/empty-file b/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/tmp/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 diff --git a/tickets/829d5f9060144a30bd44cb946b0ba1c9/ticket.yaml b/tickets/829d5f9060144a30bd44cb946b0ba1c9/ticket.yaml new file mode 100644 index 0000000..8d90ea4 --- /dev/null +++ b/tickets/829d5f9060144a30bd44cb946b0ba1c9/ticket.yaml @@ -0,0 +1,4 @@ +ticket-id: +- 829d5f9060144a30bd44cb946b0ba1c9 +title: +- Unlocking the repo from the VFS layer -- cgit v1.2.1