Date: Mon, 3 Jul 2017 08:33:10 +0300
From: Lars Wirzenius <liw@liw.fi>
To: Michele Alessandrini <m.alessandrini@univpm.it>
Message-ID: <20170703053310.7y5qri5l6mduhuli@liw.fi>
References: <0dc53aa0-b510-8607-ba63-f527f49bdf50@univpm.it>
MIME-Version: 1.0
In-Reply-To: <0dc53aa0-b510-8607-ba63-f527f49bdf50@univpm.it>
User-Agent: NeoMutt/20170113 (1.7.2)
Cc: obnam-dev@obnam.org
Subject: Re: "exclude-if-present" option
Precedence: list
Content-Type: multipart/mixed; boundary="===============8028953905777979665=="
Mime-version: 1.0
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org


--===============8028953905777979665==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="25dz43n4rurbvt5b"
Content-Disposition: inline


--25dz43n4rurbvt5b
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I've not had time to try this yet, but from reading the patch it looks
good. A few comments below.

On Thu, Jun 29, 2017 at 12:08:29PM +0200, Michele Alessandrini wrote:
> The "./check" suite mostly passes (I had to fight a little with pep8), but
> it gives some errors at the end, I suspect they're not related to code, I
> report the output at the end. Maybe I have not all the needed programs
> installed? I followed the README, and by the way I use debian testing so I
> conveniently found all your packages right in aptitude.

I'll have a look and see if I can figure out what's wrong. The README
may be out of date, but debian/control should be up to date.

> About unit tests, I found there is no similar tests for exclusion cases, =
so
> it would be difficult for me to write one from scratch, and I added it to
> "without-tests" file together with the other exclude plugins. I hope this=
 is
> not a big problem.

Yeah, that's OK. In principle it'd be good to add a yarn test for
integration testing, so that there is _some_ assurance the new feature
work. Adapting the "exclude cache directories" section in
yarns/0030-basic.yarn should be fairly easy.

(Yarn in my tool for integration testing. It's in the cmdtest package.)

> Now about the documentation: I modified the english markdown manual,
> obviously I cannot modify german and french. By the way I'm Italian, it
> would be nice if I could contribute a translation, but I'm not sure I'd h=
ave
> the needed time, and secondly I think technical things are better in
> original english. But let me know what you think.

I'd love for the Obnam manual to be translated to Italian, and other
languages. While I prefer English myself, a lot of people don't know
much or any English.

> A note: the German PDF fails to build on my computer.

I believe Jan has responsded to this. I tend to install the
texlive-full package, since life is too short to find the minimal
required set of packages from the TeX universe.

> A doubt: where is the man page? Because it needs to be updated too, but I
> can't find its sources.

See obnam.1.in for the English version. It gets filled in with
information about options automatically during the build process,
using the help text for the options.

> A suggestion: adding "*.pyc" to .gitignore, otherwise the git status is a
> mess with all the compiled python files.

I prefer to add *.pyc to my global git ignore file, instead of adding
it to .gitignore in every Python project separately.

> +    def config_loaded(self):
> +        if len(self.app.settings['exclude-if-present']) > 0:

This would feel more Pythonic to me like this:

    if self.app.settings['exclude-if-present']:

Not a big deal.

--=20
I want to build worthwhile things that might last. --joeyh

--25dz43n4rurbvt5b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEETNTnrewG6wEE1EJ3bC+mFux6IDEFAllZ1xUACgkQbC+mFux6
IDF/NQ//V936xNldXMtlDDS55UqByqYoZhRhdw2/1uWKFntva+3r7EglWkFBvMvT
1KdMfEypJ3PeUs3JwCQ0PEQrx3BIBJg/4r4p7UqLYudDk2CpCf7aZuSRriqtkw1/
TRKf8/pjlghRfDpxh/NkWx4ufEVlkZKGM+Str/0BnbJoGAPhruHV9biPeS8uSqce
fSW4UfE2b7JhnE8vncGzQmiTi1BpiM1DIojIVNgncwaAGHLOLy4YQLOq/DFLBHgk
T7UCMUi1PDYXgGOBgHapeg7SDA43KdigEuUPfgKJkuQ8mdtThXKTHPSGsqLfcAg7
0TRgRVnaob/T18fg52rmNPuwZDzOepPgRnusWMRnmlwiB44CPb4eJ13KuxeDDSJY
d2MVb+hk1WtaM2guc+v7LrifqIMJAJjCuNUAllXDUwVWQmtUkMr6ZQE8U9gSd08h
LgtV/C4yn787kdMiwcmu0enYVsrfGVC5+lWJfRbaLN3hhR08U3X6B0fGt8yavOFr
DnL/P83wvh6QOTXn6SOTpU/IHa/F4CLLLZf6+Njc7T41kqd135wiZm0jMAZWsW2o
k/8IYVqrSnc6iDiqPIccYqKOzUJ41fp/jfCJ22aR5t0XAn5pTu1PfPYu6YLhX5a3
y+D0yLhJB9nqLlFOIoL8CE6LRS+19IG1Jj39iAZH4B9o/1ZYhMI=
=Rc9u
-----END PGP SIGNATURE-----

--25dz43n4rurbvt5b--


--===============8028953905777979665==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org

--===============8028953905777979665==--