From 5b863edb32314808b6823f90c03ad97da6fdbcbf Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Sun, 7 Feb 2021 17:59:53 +0200 Subject: refactor: rename Reason::Error to Reason::GenerationLookupError New name is more precise. The meaning of the enum variant hasn't changed. --- src/backup_reason.rs | 6 +++--- src/backup_run.rs | 5 ++++- src/policy.rs | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/backup_reason.rs b/src/backup_reason.rs index 502b79e..b3ce5e9 100644 --- a/src/backup_reason.rs +++ b/src/backup_reason.rs @@ -8,7 +8,7 @@ pub enum Reason { IsNew, Changed, Unchanged, - Error, + GenerationLookupError, Unknown, } @@ -19,7 +19,7 @@ impl Reason { "new" => Reason::IsNew, "changed" => Reason::Changed, "unchanged" => Reason::Unchanged, - "error" => Reason::Error, + "genlookuperror" => Reason::GenerationLookupError, _ => Reason::Unknown, } } @@ -41,7 +41,7 @@ impl fmt::Display for Reason { Reason::IsNew => "new", Reason::Changed => "changed", Reason::Unchanged => "unchanged", - Reason::Error => "error", + Reason::GenerationLookupError => "genlookuperror", Reason::Unknown => "unknown", }; write!(f, "{}", reason) diff --git a/src/backup_run.rs b/src/backup_run.rs index f97bb58..e0ed533 100644 --- a/src/backup_run.rs +++ b/src/backup_run.rs @@ -85,7 +85,10 @@ impl BackupRun { self.progress.found_live_file(path); let reason = self.policy.needs_backup(&old, &entry); match reason { - Reason::IsNew | Reason::Changed | Reason::Error | Reason::Unknown => { + Reason::IsNew + | Reason::Changed + | Reason::GenerationLookupError + | Reason::Unknown => { let ids = self .client .upload_filesystem_entry(&entry, self.buffer_size)?; diff --git a/src/policy.rs b/src/policy.rs index 032b851..8a65e09 100644 --- a/src/policy.rs +++ b/src/policy.rs @@ -42,7 +42,7 @@ impl BackupPolicy { "needs_backup: lookup in old generation returned error, ignored: {:?}: {}", new_name, err ); - Reason::Error + Reason::GenerationLookupError } }; debug!( -- cgit v1.2.1