From 3b4b8c537f472c7ec8d90eb79d70fce11a13669c Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Sat, 7 Jan 2023 09:44:35 +0200 Subject: refactor: use idiom to iterate over keys in HashMap Found by clippy. Sponsored-by: author --- src/chunkstore.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chunkstore.rs b/src/chunkstore.rs index 750b68b..4c8125c 100644 --- a/src/chunkstore.rs +++ b/src/chunkstore.rs @@ -157,7 +157,7 @@ impl RemoteStore { let hits: HashMap = serde_json::from_slice(&body).map_err(StoreError::JsonParse)?; - let ids = hits.iter().map(|(id, _)| ChunkId::recreate(id)).collect(); + let ids = hits.keys().map(|id| ChunkId::recreate(id)).collect(); Ok(ids) } -- cgit v1.2.1 From b94fd44f231f565f5af9f200537cf8f2d219741c Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Sat, 7 Jan 2023 09:45:11 +0200 Subject: refactor: implement Default trait, instead just a function default Found by clippy. Sponsored-by: author --- src/policy.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/policy.rs b/src/policy.rs index b3ba24c..8cdbd76 100644 --- a/src/policy.rs +++ b/src/policy.rs @@ -20,15 +20,17 @@ pub struct BackupPolicy { old_if_changed: bool, } -impl BackupPolicy { +impl Default for BackupPolicy { /// Create a default policy. - pub fn default() -> Self { + fn default() -> Self { Self { new: true, old_if_changed: true, } } +} +impl BackupPolicy { /// Does a given file need to be backed up? pub fn needs_backup(&self, old: &LocalGeneration, new_entry: &FilesystemEntry) -> Reason { let new_name = new_entry.pathbuf(); -- cgit v1.2.1