From 371b445213a8d38948b655ce16f5b7ccf9ba6e46 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Fri, 10 Aug 2018 14:41:02 +0300 Subject: Add: log messages for why login fails --- qvisqve/auth_router.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/qvisqve/auth_router.py b/qvisqve/auth_router.py index 1dd769d..0313812 100644 --- a/qvisqve/auth_router.py +++ b/qvisqve/auth_router.py @@ -130,14 +130,25 @@ class AuthRouter(qvisqve.Router): qvisqve.log.log( 'trace', msg_text='extracted form parameters', params=params, username=username, password=password, attempt_id=attempt_id) + if None in (username, password, attempt_id): + qvisqve.log.log( + 'error', msg_text='Necessary form field not given', + username=username, password=password, attempt_id=attempt_id) return qvisqve.unauthorized_response('Access denied') if not self._users.is_valid_secret(username, password): + qvisqve.log.log( + 'error', + msg_text='User secret is invalid (username or password wrong)', + username=username, password=password, attempt_id=attempt_id) return qvisqve.unauthorized_response('Access denied') aa = self._attempts.find_by_id(attempt_id) if aa is None: + qvisqve.log.log( + 'error', + msg_text='Attempt ID is unknown', attempt_id=attempt_id) return qvisqve.unauthorized_response('Access denied') aa.set_subject_id(username) @@ -148,6 +159,10 @@ class AuthRouter(qvisqve.Router): redirect_uri = aa.get_redirect_uri() if redirect_uri == '': + qvisqve.log.log( + 'error', + msg_text='redirect_uri is unknown', + redirect_uri=repr(redirect_uri)) return qvisqve.bad_request_response('Bad request') params = { -- cgit v1.2.1