diff options
author | Daniel Silverstone <dsilvers+gitlab@digital-scurf.org> | 2021-02-17 08:21:06 +0000 |
---|---|---|
committer | Daniel Silverstone <dsilvers+gitlab@digital-scurf.org> | 2021-02-17 08:21:06 +0000 |
commit | 337c6dd6cd4075f8352e8729d1decc9c0002a845 (patch) | |
tree | 3cf638e1f6aab40ef251658bdb25002fa86ecd0b | |
parent | 55dd0dcdf1432bbca35cbfc3be63f88d1fa0b0e6 (diff) | |
parent | ca6f4f01a9d4c20b7b3119b3e4bee9cf3ba280b8 (diff) | |
download | subplot-337c6dd6cd4075f8352e8729d1decc9c0002a845.tar.gz |
Merge branch 'get-title-no-result' into 'main'
refactor: get_title can't fail, so don't return a Result
See merge request larswirzenius/subplot!137
-rw-r--r-- | src/metadata.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/metadata.rs b/src/metadata.rs index b947854..3f4916a 100644 --- a/src/metadata.rs +++ b/src/metadata.rs @@ -27,7 +27,7 @@ impl Metadata { where P: AsRef<Path>, { - let title = get_title(&doc.meta)?; + let title = get_title(&doc.meta); let date = get_date(&doc.meta); let bindings_filenames = get_bindings_filenames(basedir.as_ref(), &doc.meta); let functions_filenames = get_functions_filenames(basedir.as_ref(), &doc.meta); @@ -109,11 +109,11 @@ impl Metadata { type Mapp = Map<String, MetaValue>; -fn get_title(map: &Mapp) -> Result<String> { +fn get_title(map: &Mapp) -> String { if let Some(s) = get_string(map, "title") { - Ok(s) + s } else { - Ok("".to_string()) + "".to_string() } } |