diff options
| author | Andy Piper <andy.piper@arcticwolf.com> | 2021-11-22 20:30:11 -0500 |
|---|---|---|
| committer | Andy Piper <andy.piper@arcticwolf.com> | 2021-11-22 20:30:11 -0500 |
| commit | 788d4b1e920db40a0ad32361255e0d59cdbec829 (patch) | |
| tree | 503734a7c38abfb0b144402e49f8022439b0e692 | |
| parent | 971521502bff4d1d7ab4c03077142a379ad6c726 (diff) | |
| download | vmdb2-788d4b1e920db40a0ad32361255e0d59cdbec829.tar.gz | |
debootstrap_plugin: don't always run apt-get update
The apt_plugin always runs `apt-get update` before installing packages,
so the `apt-get update` in deboostrap_plugin is redundant. It also
blocks provisioning the TLS certs required to validate connections to
package repos that use https instead of http connections.
| -rw-r--r-- | vmdb/plugins/debootstrap.mdwn | 3 | ||||
| -rw-r--r-- | vmdb/plugins/debootstrap_plugin.py | 4 |
2 files changed, 0 insertions, 7 deletions
diff --git a/vmdb/plugins/debootstrap.mdwn b/vmdb/plugins/debootstrap.mdwn index 322cf6b..67f13fb 100644 --- a/vmdb/plugins/debootstrap.mdwn +++ b/vmdb/plugins/debootstrap.mdwn @@ -4,9 +4,6 @@ Step: debootstrap Create a directory tree with a basic Debian installation. This does not include a boot loader. -A side effect of this step is that `apt-get update` is **always** run, -even if the step is otherwise skipped using `unless`. - Step keys: * `debootstrap` — REQUIRED; value is the codename of the Debian diff --git a/vmdb/plugins/debootstrap_plugin.py b/vmdb/plugins/debootstrap_plugin.py index 4922690..92d23d4 100644 --- a/vmdb/plugins/debootstrap_plugin.py +++ b/vmdb/plugins/debootstrap_plugin.py @@ -85,7 +85,3 @@ class DebootstrapStepRunner(vmdb.StepRunnerInterface): ] ) - def run_even_if_skipped(self, values, settings, state): - tag = values["target"] - target = state.tags.get_builder_mount_point(tag) - vmdb.runcmd_chroot(target, ["apt-get", "update"]) |