summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars Wirzenius <liw@liw.fi>2020-04-05 14:13:06 +0300
committerLars Wirzenius <liw@liw.fi>2020-04-05 14:13:06 +0300
commit1319a03c3ecfaf812da24813a2d71cb406033836 (patch)
tree69be40d4d73188fd1579a2674537267da53ad3a6
parent7c17dd392783f601dbb32b14b833e42f9aee56ca (diff)
downloadvmdb2-1319a03c3ecfaf812da24813a2d71cb406033836.tar.gz
Fix: drop unnecessary get_required_keys methods
No step runner needs to implement that method, ever. StepRunnerInterface provides it.
-rw-r--r--vmdb/plugins/debootstrap_plugin.py3
-rw-r--r--vmdb/plugins/error_plugin.py3
-rw-r--r--vmdb/plugins/shell_plugin.py7
3 files changed, 5 insertions, 8 deletions
diff --git a/vmdb/plugins/debootstrap_plugin.py b/vmdb/plugins/debootstrap_plugin.py
index f2f284b..2d93dea 100644
--- a/vmdb/plugins/debootstrap_plugin.py
+++ b/vmdb/plugins/debootstrap_plugin.py
@@ -39,9 +39,6 @@ class DebootstrapStepRunner(vmdb.StepRunnerInterface):
'variant': '-',
}
- def get_required_keys(self):
- return ['debootstrap', 'target', 'mirror']
-
def run(self, values, settings, state):
suite = values['debootstrap']
tag = values['target']
diff --git a/vmdb/plugins/error_plugin.py b/vmdb/plugins/error_plugin.py
index 7c5ce8c..bed7319 100644
--- a/vmdb/plugins/error_plugin.py
+++ b/vmdb/plugins/error_plugin.py
@@ -36,9 +36,6 @@ class ErrorStepRunner(vmdb.StepRunnerInterface):
'teardown': str,
}
- def get_required_keys(self):
- return ['error', 'teardown']
-
def run(self, values, settings, state):
# We use vmdb.progress here to get output to go to stdout,
# instead of stderr. We want that for tests.
diff --git a/vmdb/plugins/shell_plugin.py b/vmdb/plugins/shell_plugin.py
index ecbbbfa..cbc52ea 100644
--- a/vmdb/plugins/shell_plugin.py
+++ b/vmdb/plugins/shell_plugin.py
@@ -32,8 +32,11 @@ class ShellPlugin(cliapp.Plugin):
class ShellStepRunner(vmdb.StepRunnerInterface):
- def get_required_keys(self):
- return ['shell', 'root-fs']
+ def get_key_spec(self):
+ return {
+ 'shell': str,
+ 'root-fs': str,
+ }
def run(self, step, settings, state):
shell = step['shell']