diff options
| author | Dan Duvall <dduvall@wikimedia.org> | 2017-07-12 11:54:25 -0700 |
|---|---|---|
| committer | Dan Duvall <dduvall@wikimedia.org> | 2017-07-17 08:57:56 -0700 |
| commit | 3071d9290e5f91c11e4682cebde558346c4a0908 (patch) | |
| tree | ea57bf3117dd74c768a558d773b865049397e6e6 /build | |
| parent | 19b47a273717612e28374be9b63905985ce32ac9 (diff) | |
| download | blubber-3071d9290e5f91c11e4682cebde558346c4a0908.tar.gz | |
Quote CLI arguments in `RunsConfig` instructions
Summary:
Refactored build instructions in `RunsConfig` to properly quote command
arguments injected from user data.
Established unit tests for `RunsConfig` instruction phases.
Refs T170285. Depends on D711
Omit ENV instruction when `runs.environment` is empty
Fixes T170285
Test Plan:
Run `arc unit`. Create a config without `runs.environment` defined and verify
that no bare `ENV` line ends up in the `Dockerfile` output.
Reviewers: thcipriani, hashar, mmodell, #release-engineering-team
Reviewed By: thcipriani, #release-engineering-team
Tags: #release-engineering-team
Maniphest Tasks: T170285
Differential Revision: https://phabricator.wikimedia.org/D715
Diffstat (limited to 'build')
0 files changed, 0 insertions, 0 deletions