Broaden base test coverage

Summary:
Implemented tests for config types and removed deprecated docker
compiler tests.

Fixes T168001

Test Plan: Run `arc unit --everything` or `go test ./...`.

Reviewers: thcipriani, mmodell, #release-engineering-team

Reviewed By: thcipriani, #release-engineering-team

Tags: #release-engineering-team

Maniphest Tasks: T168001

Differential Revision: https://phabricator.wikimedia.org/D711

1 files changed, 0 insertions, 20 deletions

diff --git a/docker/compiler_test.go b/docker/compiler_test.go
index 8981683..d6a1a53 100644
--- a/docker/compiler_test.go
+++ b/docker/compiler_test.go
@@ -1,12 +1,10 @@
 package docker_test
 
 import (
-	"bytes"
 	"testing"
 
 	"gopkg.in/stretchr/testify.v1/assert"
 
-	"phabricator.wikimedia.org/source/blubber.git/build"
 	"phabricator.wikimedia.org/source/blubber.git/config"
 	"phabricator.wikimedia.org/source/blubber.git/docker"
 )
@@ -42,21 +40,3 @@ func TestMultiStageIncludesStageNames(t *testing.T) {
 	assert.Contains(t, dockerfile, "FROM foo/bar AS build\n")
 	assert.Contains(t, dockerfile, "FROM foo/bar AS production\n")
 }
-
-func TestCompileInstructionCopy(t *testing.T) {
-	buffer := new(bytes.Buffer)
-	instruction := build.Instruction{build.Copy, []string{"foo", "bar"}}
-
-	docker.CompileInstruction(buffer, instruction)
-
-	assert.Equal(t, "COPY [\"foo\", \"bar\"]\n", buffer.String())
-}
-
-func TestCompileInstructionEnv(t *testing.T) {
-	buffer := new(bytes.Buffer)
-	instruction := build.Instruction{build.Env, []string{"foo=bar", "baz=qux"}}
-
-	docker.CompileInstruction(buffer, instruction)
-
-	assert.Equal(t, "ENV foo=bar \\\n    baz=qux\n", buffer.String())
-}