diff options
| author | Dan Duvall <dduvall@wikimedia.org> | 2018-09-17 16:00:05 -0700 |
|---|---|---|
| committer | Dan Duvall <dduvall@wikimedia.org> | 2018-10-01 16:40:20 -0700 |
| commit | af9e797908c0d5ed7780a5386aa773ecdd9cc51c (patch) | |
| tree | f8894bca5a9c40875b708a86554fcd922ca15380 /docker | |
| parent | df5e386938769c48c604b2d1804f505d6faf6594 (diff) | |
| download | blubber-af9e797908c0d5ed7780a5386aa773ecdd9cc51c.tar.gz | |
Remove support for `sharedvolume` configuration
Support for mounting a shared volume instead of copying application
files was meant to provide an option for development use cases. This
functionality has never been thoroughly tested or utilized for any use
case. It should be removed for now.
Relates tangentially to task T204591 that simplifies node support.
Change-Id: Ib70cb7bceb504841897a38d732880ba376fe67c8
Diffstat (limited to 'docker')
| -rw-r--r-- | docker/instructions.go | 4 | ||||
| -rw-r--r-- | docker/instructions_test.go | 10 |
2 files changed, 0 insertions, 14 deletions
diff --git a/docker/instructions.go b/docker/instructions.go index 8f5c63c..4095eb4 100644 --- a/docker/instructions.go +++ b/docker/instructions.go @@ -51,10 +51,6 @@ func NewInstruction(bi build.Instruction) (Instruction, error) { case build.User: i.name = "USER" - case build.Volume: - i.name = "VOLUME" - i.array = true - case build.WorkingDirectory: i.name = "WORKDIR" } diff --git a/docker/instructions_test.go b/docker/instructions_test.go index b89a721..7124ff0 100644 --- a/docker/instructions_test.go +++ b/docker/instructions_test.go @@ -113,16 +113,6 @@ func TestUser(t *testing.T) { } } -func TestVolume(t *testing.T) { - i := build.Volume{"/foo/dir"} - - di, err := docker.NewInstruction(i) - - if assert.NoError(t, err) { - assert.Equal(t, "VOLUME [\"/foo/dir\"]\n", di.Compile()) - } -} - func TestWorkingDirectory(t *testing.T) { i := build.WorkingDirectory{"/foo/dir"} |