1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
package config_test
import (
"testing"
"github.com/stretchr/testify/assert"
"phabricator.wikimedia.org/source/blubber/build"
"phabricator.wikimedia.org/source/blubber/config"
)
func TestRunsConfigYAML(t *testing.T) {
cfg, err := config.ReadConfig([]byte(`---
version: v2
base: foo
runs:
as: someuser
insecurely: true
uid: 666
gid: 777
environment: { FOO: bar }
variants:
development: {}`))
assert.Nil(t, err)
variant, err := config.ExpandVariant(cfg, "development")
assert.Nil(t, err)
assert.Equal(t, "someuser", variant.Runs.As)
assert.Equal(t, true, variant.Runs.Insecurely.True)
assert.Equal(t, uint(666), variant.Runs.UID)
assert.Equal(t, uint(777), variant.Runs.GID)
assert.Equal(t, map[string]string{"FOO": "bar"}, variant.Runs.Environment)
}
func TestRunsConfigInstructions(t *testing.T) {
cfg := config.RunsConfig{
UserConfig: config.UserConfig{
As: "someuser",
UID: 666,
GID: 777,
},
Environment: map[string]string{
"fooname": "foovalue",
"barname": "barvalue",
},
}
t.Run("PhasePrivileged", func(t *testing.T) {
assert.Equal(t,
[]build.Instruction{build.RunAll{[]build.Run{
{"groupadd -o -g %s -r", []string{"777", "someuser"}},
{"useradd -o -m -d %s -r -g %s -u %s", []string{"/home/someuser", "someuser", "666", "someuser"}},
}}},
cfg.InstructionsForPhase(build.PhasePrivileged),
)
})
t.Run("PhasePrivilegeDropped", func(t *testing.T) {
assert.Equal(t,
[]build.Instruction{
build.Env{map[string]string{"barname": "barvalue", "fooname": "foovalue"}},
},
cfg.InstructionsForPhase(build.PhasePrivilegeDropped),
)
t.Run("with empty Environment", func(t *testing.T) {
cfg.Environment = map[string]string{}
assert.Empty(t, cfg.InstructionsForPhase(build.PhasePrivilegeDropped))
})
})
t.Run("PhasePreInstall", func(t *testing.T) {
assert.Empty(t, cfg.InstructionsForPhase(build.PhasePreInstall))
})
t.Run("PhasePostInstall", func(t *testing.T) {
assert.Empty(t, cfg.InstructionsForPhase(build.PhasePostInstall))
})
}
func TestRunsConfigValidation(t *testing.T) {
t.Run("environment", func(t *testing.T) {
t.Run("ok", func(t *testing.T) {
err := config.Validate(config.RunsConfig{
Environment: map[string]string{
"foo": "bar",
"f1oo": "bar",
"FOO": "bar",
"foo_fighter": "bar",
"FOO_FIGHTER": "bar",
"_FOO_FIGHTER": "bar",
},
})
assert.False(t, config.IsValidationError(err))
})
t.Run("optional", func(t *testing.T) {
err := config.Validate(config.RunsConfig{})
assert.False(t, config.IsValidationError(err))
})
t.Run("bad", func(t *testing.T) {
t.Run("spaces", func(t *testing.T) {
err := config.Validate(config.RunsConfig{
Environment: map[string]string{
"foo fighter": "bar",
},
})
if assert.True(t, config.IsValidationError(err)) {
msg := config.HumanizeValidationError(err)
assert.Equal(t, `environment: contains invalid environment variable names`, msg)
}
})
t.Run("dashes", func(t *testing.T) {
err := config.Validate(config.RunsConfig{
Environment: map[string]string{
"foo-fighter": "bar",
},
})
if assert.True(t, config.IsValidationError(err)) {
msg := config.HumanizeValidationError(err)
assert.Equal(t, `environment: contains invalid environment variable names`, msg)
}
})
t.Run("dots", func(t *testing.T) {
err := config.Validate(config.RunsConfig{
Environment: map[string]string{
"foo.fighter": "bar",
},
})
if assert.True(t, config.IsValidationError(err)) {
msg := config.HumanizeValidationError(err)
assert.Equal(t, `environment: contains invalid environment variable names`, msg)
}
})
t.Run("starts with number", func(t *testing.T) {
err := config.Validate(config.RunsConfig{
Environment: map[string]string{
"1foo": "bar",
},
})
if assert.True(t, config.IsValidationError(err)) {
msg := config.HumanizeValidationError(err)
assert.Equal(t, `environment: contains invalid environment variable names`, msg)
}
})
})
})
}
|
