1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
|
Return-Path: <ick-discuss-bounces@ick.liw.fi>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from yaffle.pepperfish.net (yaffle.pepperfish.net [88.99.213.221])
by pieni.net (Postfix) with ESMTPS id 616C7409C6
for <distix@pieni.net>; Wed, 4 Apr 2018 07:08:27 +0000 (UTC)
Received: from platypus.pepperfish.net (unknown [10.112.101.20])
by yaffle.pepperfish.net (Postfix) with ESMTP id 3F057417E9
for <distix@pieni.net>; Wed, 4 Apr 2018 08:08:27 +0100 (BST)
Received: from ip6-localhost.nat ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1f3cWx-0002LW-6Z; Wed, 04 Apr 2018 08:08:27 +0100
Received: from [10.112.101.104] (helo=mx4.pepperfish.net)
by platypus.pepperfish.net with esmtps (Exim 4.80 #2 (Debian))
id 1f3cWw-0002LG-2j
for <ick-discuss@ick.liw.fi>; Wed, 04 Apr 2018 08:08:26 +0100
Received: from mail.steve.org.uk ([176.9.183.102] helo=ssh.steve.org.uk)
by mx4.pepperfish.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.89) (envelope-from <steve@steve.org.uk>) id 1f3cWs-0006Vo-MA
for ick-discuss@ick.liw.fi; Wed, 04 Apr 2018 07:08:25 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=steve.org.uk; s=20150726; h=References:In-Reply-To:Message-ID:Date:Subject:
From:Cc:To:Sender:Reply-To:MIME-Version:Content-Type:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=QkXtUX4CsTBU3Ty6KsEZgPbDWBjZulUMYqBMwH0pI+g=; b=SBZH5RUH2NP0OYYqKZ3WQjFuF
lcIsXtGu9nXk8d+qU7efiELyx5sz+KZWWwNS7Lk7fRohO8pxclx6iStzUF3d6zVsKpoVXh+dl6FXl
2JHoZO+ASgHRb1iLgd46sRHa/1xG8SkXNGOuuQwUPS6fQhTML1STJYts4Xcqyyy9e3cHQ=;
Received: from steve by ssh.steve.org.uk with local (Exim 4.89)
(envelope-from <steve@steve.org.uk>) id 1f3cWk-0005Ec-3i
for ick-discuss@ick.liw.fi; Wed, 04 Apr 2018 07:08:14 +0000
To: ick-discuss@ick.liw.fi
Cc:
From: Steve Kemp <steve@steve.org.uk>
Date: Wed, 04 Apr 2018 07:05:50 +0000
Message-ID: <1522825550.19550.4@ssh.steve.org.uk>
In-Reply-To: <1522825244.6263.6.camel@liw.fi>
References: <1522825244.6263.6.camel@liw.fi>
X-added-header: steve.org.uk
X-Pepperfish-Transaction: 5e3b-e8d8-e951-882b
X-Spam-Score: 2.4
X-Spam-Score-int: 24
X-Spam-Bar: ++
X-Scanned-By: pepperfish.net, Wed, 04 Apr 2018 07:08:25 +0000
X-Spam-Report: Content analysis details: (2.4 points)
pts rule name description
---- ---------------------- --------------------------------------------------
2.5 PPF_GTLD_LONG Long gTLD, probably cheap throw-away domain
-0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
domain
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-ACL-Warn: message may be spam
X-Scan-Signature: 33c28d4dad91734d931da14cc3b51e8a
Subject: Re: Notification system for ick
X-BeenThere: ick-discuss@ick.liw.fi
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: discussions about the ick CI system <ick-discuss-ick.liw.fi>
List-Unsubscribe: <https://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/ick-discuss-ick.liw.fi>,
<mailto:ick-discuss-request@ick.liw.fi?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/ick-discuss-ick.liw.fi>
List-Post: <mailto:ick-discuss@ick.liw.fi>
List-Help: <mailto:ick-discuss-request@ick.liw.fi?subject=help>
List-Subscribe: <https://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/ick-discuss-ick.liw.fi>,
<mailto:ick-discuss-request@ick.liw.fi?subject=subscribe>
Sender: ick-discuss-bounces@ick.liw.fi
Errors-To: ick-discuss-bounces@ick.liw.fi
> I'd welcome feedback on this (text reproduced below):
> http://ick.liw.fi/blog/2018/04/04/notifications_in_ick_the_mvp/
>
> Would that be sufficiently useful for your initial needs? Is there
> something there you'd be willing to do without?
It looks sane, the controller must trigger the notication(s) because
it is in charge of the build. The controller doesn't need to have
notification methods hardwired, so it should defer to an external
worker.
(Though presumably the worker will be on the same host, I can't
imagine you'd want the notifications to be triggered on the
build-hosts!)
The only change I'd suggest is that I'd rather see ALL the build-log
than just the last N lines.
Steve
--
_______________________________________________
ick-discuss mailing list
ick-discuss@ick.liw.fi
https://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/ick-discuss-ick.liw.fi
|
