summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorDaniel Silverstone <dsilvers@digital-scurf.org>2017-08-27 14:25:21 +0100
committerLars Wirzenius <liw@liw.fi>2017-08-27 14:27:30 +0100
commit9e911158ec2989655690780ad8fce9b9a8dfbf60 (patch)
tree27b2d6274e78c3339a8b9d4b267bd321677185bb /arch
parent6f1dab88aabf33a5d4d4e33bfa28fd9f227a9d55 (diff)
downloadick2-9e911158ec2989655690780ad8fce9b9a8dfbf60.tar.gz
Rework notification of trigger service diagram
Diffstat (limited to 'arch')
-rw-r--r--arch/ick2-arch.mdwn17
1 files changed, 7 insertions, 10 deletions
diff --git a/arch/ick2-arch.mdwn b/arch/ick2-arch.mdwn
index a9ade5a..1383fe5 100644
--- a/arch/ick2-arch.mdwn
+++ b/arch/ick2-arch.mdwn
@@ -457,20 +457,17 @@ trusty -> controller : POST /worker/trusty, exit=0 (token E)
|||
trusty -> controller : GET /worker/trusty (token E)
-controller -> trusty : "notify trigger service pipeline is finished"
-trusty -> controller : POST /worker/trusty, exit=0 (token E)
+controller -> trusty : "notify trigger service pipeline is finished **successfully**"
+trusty -> trigger : GET /pipelines/website/getsource, exit=0 (token E)
note right
- note that we need to tell controller this last step is finished
- **before** telling the trigger service the pipeline is finished,
- otherwise there is a race condition
+ No need to have the trigger service query the controller since
+ it has been told the status of pipeline by the worker.
end note
-trusty -> trigger : GET /pipelines/website/getsource (token E)
-trigger -> controller : GET /projects/website/pipelines/getsource (token D)
+trusty -> controller : POST /worker/trusty, exit=0 (token E)
note right
- Trigger service checks
- status of pipeline
+ If the notification to the trigger service failed,
+ this can be reported to the controller for logging.
end note
-controller --> trigger : "pipeline is has finished successfully"
trigger -> controller : POST /projects/website/pipelines/ikiwiki/+start (token D)
@enduml