Refactor: simplify generation/yielding of job ids

1 files changed, 18 insertions, 1 deletions

diff --git a/simplejenkinsapi/jobconfig.py b/simplejenkinsapi/jobconfig.py
index 3bc2773..a53fd54 100644
--- a/simplejenkinsapi/jobconfig.py
+++ b/simplejenkinsapi/jobconfig.py
@@ -54,7 +54,10 @@ class JobConfig(object):
         self._project = ET.fromstring(empty)
         self._tree = ET.ElementTree(self._project)
         self._param_dicts = []
-        
+
+    def set_job_suffix(self, suffix):
+        self._suffix = suffix
+
     def add_param_dict(self, prefix, param_dict):
         self._param_dicts.append((prefix, param_dict))
         
@@ -65,6 +68,20 @@ class JobConfig(object):
                 unified['%s.%s' % (prefix, key)] = param_dict[key]
         return unified
 
+    def job_id(self):
+        '''Create a unique job id from constituent parts.
+        
+        Escape characters that Jenkins gets upset by, such as '@'.
+        
+        '''
+
+        def esc(s):
+            s = '.'.join(s.split('@'))
+            return s
+
+        s = '%(project.name)s_%(host.ssh-target)s_' % self._get_params()
+        return esc(s) + self._suffix
+
     def tostring(self):
         f = StringIO.StringIO()
         self._tree.write(