diff options
author | Lars Wirzenius <liw@liw.fi> | 2016-02-20 22:10:13 +0200 |
---|---|---|
committer | Lars Wirzenius <liw@liw.fi> | 2016-02-20 22:10:13 +0200 |
commit | 8c087e41fdda5d9508b9c95ea57fbd079142633d (patch) | |
tree | 44bbbcec3aac27d6ca26d498ac1b4f77ae15c190 /tickets/3979d2a6019547edaa6ebd332f80cc78 | |
parent | ea12bbd09cf9e03d4b50f139f55925aad10dcec0 (diff) | |
download | obnam-dev-distix-8c087e41fdda5d9508b9c95ea57fbd079142633d.tar.gz |
imported mails
Diffstat (limited to 'tickets/3979d2a6019547edaa6ebd332f80cc78')
7 files changed, 437 insertions, 0 deletions
diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/cur/.this-dir-not-empty/.empty/empty-file b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/cur/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/cur/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/.this-dir-not-empty/.empty/empty-file b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M227267P17339Q45.exolobe1 b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M227267P17339Q45.exolobe1 new file mode 100644 index 0000000..db6477b --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M227267P17339Q45.exolobe1 @@ -0,0 +1,159 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 8C3DC2C581 + for <distix@pieni.net>; Fri, 27 Feb 2015 14:16:45 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id A87E53551; + Fri, 27 Feb 2015 13:16:44 +0000 (GMT) +Received: from localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRKma-0004KL-Iu; Fri, 27 Feb 2015 13:16:44 +0000 +Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRKmY-0004KE-Ry + for <obnam-dev@obnam.org>; Fri, 27 Feb 2015 13:16:42 +0000 +Received: from mail-pd0-f175.google.com ([209.85.192.175]) + by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) + (Exim 4.80) (envelope-from <thomas.j.waldmann@gmail.com>) + id 1YRKmV-0001MD-He + for obnam-dev@obnam.org; Fri, 27 Feb 2015 13:16:42 +0000 +Received: by pdjy10 with SMTP id y10so21030137pdj.6 + for <obnam-dev@obnam.org>; Fri, 27 Feb 2015 05:16:30 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:date:message-id:subject:from:to:content-type; + bh=FnjvR7wffVxYq4GzM3dSbOWuvsiark5rdQ2cioYzA0I=; + b=pfyE4KmK+3/8FHz41v6TrvT7AzMgUmIGbi0pqHYP+4SazypjqIqECyVcpOLJFXySRv + yzVfKIPE2IB8jocp4GoUUqtCgdX9H2Ahfr+P/DnVyubo70rtcAAa8i3dwrVY2ko/qBqu + cdrligV0GPkDtqMH7APDs7AJr5kG9BDV27m7raS6vkhpi53IRknZ252pTOyoDkBH+7m4 + SGJwVswfiPWM7JcXxA7Alrw78Iap9u5wec2uHFoLyE1k9BiZ+beHEISKMTy/8njodC0B + r6Ui9xfPgGZU8ewFx7JWIcJ1Q66XEC22MDppv3nwIkxmBePpTwPXSQyX1lsB1/9jsWFL + sfVQ== +MIME-Version: 1.0 +X-Received: by 10.66.124.129 with SMTP id mi1mr23660931pab.21.1425042989143; + Fri, 27 Feb 2015 05:16:29 -0800 (PST) +Received: by 10.66.185.45 with HTTP; Fri, 27 Feb 2015 05:16:29 -0800 (PST) +Date: Fri, 27 Feb 2015 14:16:29 +0100 +Message-ID: <CAF+2JmHevknkwghCPN2YJVEUE-VYkN-b6rh4D=0KhWhBvqw+pg@mail.gmail.com> +From: Thomas Waldmann <thomas.j.waldmann@gmail.com> +To: obnam-dev@obnam.org +X-Spam-Score: 0.7 +X-Spam-Score-int: 7 +X-Spam-Bar: / +X-Scanned-By: pepperfish.net, Fri, 27 Feb 2015 13:16:41 +0000 +X-Spam-Report: Content analysis details: (0.7 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.2 PPF_ALTERNATIVES Body in multipart/alternative + 0.5 PPF_RECEIVED_HTTP Received header mentions http + 1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail' + 1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider + (thomas.j.waldmann[at]gmail.com) + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [209.85.192.175 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] + 0.3 HTML_MESSAGE BODY: HTML included in message + 0.2 PPF_NUMERIC_ENTITY RAW: Body contains numeric HTML entities + -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's + domain + 0.1 DKIM_SIGNED Message has a DKIM or DK signature, + not necessarily valid + -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature +Subject: [PATCH] verify_plugin: verify_chunks - consider case when live file + has grown +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Content-Type: multipart/mixed; boundary="===============4839776383272810965==" +Mime-version: 1.0 +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +--===============4839776383272810965== +Content-Type: multipart/alternative; boundary=001a113441b028612c051011aded + +--001a113441b028612c051011aded +Content-Type: text/plain; charset=UTF-8 + +When the live file has new data appended at the end, the verification +should fail. + +It previously did not, because it only compared the data up to the length +of all backup data chunks (== the backupped file's length). +--- + obnamlib/plugins/verify_plugin.py | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/obnamlib/plugins/verify_plugin.py +b/obnamlib/plugins/verify_plugin.py +index 50cd1d0..9e1ae7c 100644 +--- a/obnamlib/plugins/verify_plugin.py ++++ b/obnamlib/plugins/verify_plugin.py +@@ -207,6 +207,10 @@ class VerifyPlugin(obnamlib.ObnamPlugin): + self.app.ts['done_bytes'] += len(backed_up) + if backed_up != live_data: + return False ++ # check whether more data has been appended to the live data ++ live_data = f.read(1) ++ if live_data: ++ return False + return True + + def walk(self, gen_id, args): +-- +1.9.1 + +--001a113441b028612c051011aded +Content-Type: text/html; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +<div dir=3D"ltr">When the live file has new data appended at the end, the v= +erification should fail.<br><br>It previously did not, because it only comp= +ared the data up to the length of all backup data chunks (=3D=3D the backup= +ped file's length).<br>---<br>=C2=A0obnamlib/plugins/verify_plugin.py |= + 4 ++++<br>=C2=A01 file changed, 4 insertions(+)<br><br>diff --git a/obnaml= +ib/plugins/verify_plugin.py b/obnamlib/plugins/verify_plugin.py<br>index 50= +cd1d0..9e1ae7c 100644<br>--- a/obnamlib/plugins/verify_plugin.py<br>+++ b/o= +bnamlib/plugins/verify_plugin.py<br>@@ -207,6 +207,10 @@ class VerifyPlugin= +(obnamlib.ObnamPlugin):<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0=C2=A0=C2=A0=C2=A0 self.app.ts['done_bytes'] +=3D len(backed_= +up)<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0 if backed_up !=3D live_data:<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return False<b= +r>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # check whether more data has= + been appended to the live data<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= +=A0 live_data =3D f.read(1)<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = +if live_data:<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= +=A0=C2=A0 return False<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = +return True<br>=C2=A0<br>=C2=A0=C2=A0=C2=A0=C2=A0 def walk(self, gen_id, ar= +gs):<br>-- <br>1.9.1<br><br></div> + +--001a113441b028612c051011aded-- + + +--===============4839776383272810965== +Content-Type: text/plain; charset="us-ascii" +MIME-Version: 1.0 +Content-Transfer-Encoding: 7bit +Content-Disposition: inline + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org + +--===============4839776383272810965==-- + diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M264024P17339Q47.exolobe1 b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M264024P17339Q47.exolobe1 new file mode 100644 index 0000000..db6477b --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455998996.M264024P17339Q47.exolobe1 @@ -0,0 +1,159 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 8C3DC2C581 + for <distix@pieni.net>; Fri, 27 Feb 2015 14:16:45 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id A87E53551; + Fri, 27 Feb 2015 13:16:44 +0000 (GMT) +Received: from localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRKma-0004KL-Iu; Fri, 27 Feb 2015 13:16:44 +0000 +Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRKmY-0004KE-Ry + for <obnam-dev@obnam.org>; Fri, 27 Feb 2015 13:16:42 +0000 +Received: from mail-pd0-f175.google.com ([209.85.192.175]) + by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) + (Exim 4.80) (envelope-from <thomas.j.waldmann@gmail.com>) + id 1YRKmV-0001MD-He + for obnam-dev@obnam.org; Fri, 27 Feb 2015 13:16:42 +0000 +Received: by pdjy10 with SMTP id y10so21030137pdj.6 + for <obnam-dev@obnam.org>; Fri, 27 Feb 2015 05:16:30 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:date:message-id:subject:from:to:content-type; + bh=FnjvR7wffVxYq4GzM3dSbOWuvsiark5rdQ2cioYzA0I=; + b=pfyE4KmK+3/8FHz41v6TrvT7AzMgUmIGbi0pqHYP+4SazypjqIqECyVcpOLJFXySRv + yzVfKIPE2IB8jocp4GoUUqtCgdX9H2Ahfr+P/DnVyubo70rtcAAa8i3dwrVY2ko/qBqu + cdrligV0GPkDtqMH7APDs7AJr5kG9BDV27m7raS6vkhpi53IRknZ252pTOyoDkBH+7m4 + SGJwVswfiPWM7JcXxA7Alrw78Iap9u5wec2uHFoLyE1k9BiZ+beHEISKMTy/8njodC0B + r6Ui9xfPgGZU8ewFx7JWIcJ1Q66XEC22MDppv3nwIkxmBePpTwPXSQyX1lsB1/9jsWFL + sfVQ== +MIME-Version: 1.0 +X-Received: by 10.66.124.129 with SMTP id mi1mr23660931pab.21.1425042989143; + Fri, 27 Feb 2015 05:16:29 -0800 (PST) +Received: by 10.66.185.45 with HTTP; Fri, 27 Feb 2015 05:16:29 -0800 (PST) +Date: Fri, 27 Feb 2015 14:16:29 +0100 +Message-ID: <CAF+2JmHevknkwghCPN2YJVEUE-VYkN-b6rh4D=0KhWhBvqw+pg@mail.gmail.com> +From: Thomas Waldmann <thomas.j.waldmann@gmail.com> +To: obnam-dev@obnam.org +X-Spam-Score: 0.7 +X-Spam-Score-int: 7 +X-Spam-Bar: / +X-Scanned-By: pepperfish.net, Fri, 27 Feb 2015 13:16:41 +0000 +X-Spam-Report: Content analysis details: (0.7 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.2 PPF_ALTERNATIVES Body in multipart/alternative + 0.5 PPF_RECEIVED_HTTP Received header mentions http + 1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail' + 1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider + (thomas.j.waldmann[at]gmail.com) + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [209.85.192.175 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] + 0.3 HTML_MESSAGE BODY: HTML included in message + 0.2 PPF_NUMERIC_ENTITY RAW: Body contains numeric HTML entities + -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's + domain + 0.1 DKIM_SIGNED Message has a DKIM or DK signature, + not necessarily valid + -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature +Subject: [PATCH] verify_plugin: verify_chunks - consider case when live file + has grown +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Content-Type: multipart/mixed; boundary="===============4839776383272810965==" +Mime-version: 1.0 +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +--===============4839776383272810965== +Content-Type: multipart/alternative; boundary=001a113441b028612c051011aded + +--001a113441b028612c051011aded +Content-Type: text/plain; charset=UTF-8 + +When the live file has new data appended at the end, the verification +should fail. + +It previously did not, because it only compared the data up to the length +of all backup data chunks (== the backupped file's length). +--- + obnamlib/plugins/verify_plugin.py | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/obnamlib/plugins/verify_plugin.py +b/obnamlib/plugins/verify_plugin.py +index 50cd1d0..9e1ae7c 100644 +--- a/obnamlib/plugins/verify_plugin.py ++++ b/obnamlib/plugins/verify_plugin.py +@@ -207,6 +207,10 @@ class VerifyPlugin(obnamlib.ObnamPlugin): + self.app.ts['done_bytes'] += len(backed_up) + if backed_up != live_data: + return False ++ # check whether more data has been appended to the live data ++ live_data = f.read(1) ++ if live_data: ++ return False + return True + + def walk(self, gen_id, args): +-- +1.9.1 + +--001a113441b028612c051011aded +Content-Type: text/html; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +<div dir=3D"ltr">When the live file has new data appended at the end, the v= +erification should fail.<br><br>It previously did not, because it only comp= +ared the data up to the length of all backup data chunks (=3D=3D the backup= +ped file's length).<br>---<br>=C2=A0obnamlib/plugins/verify_plugin.py |= + 4 ++++<br>=C2=A01 file changed, 4 insertions(+)<br><br>diff --git a/obnaml= +ib/plugins/verify_plugin.py b/obnamlib/plugins/verify_plugin.py<br>index 50= +cd1d0..9e1ae7c 100644<br>--- a/obnamlib/plugins/verify_plugin.py<br>+++ b/o= +bnamlib/plugins/verify_plugin.py<br>@@ -207,6 +207,10 @@ class VerifyPlugin= +(obnamlib.ObnamPlugin):<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0=C2=A0=C2=A0=C2=A0 self.app.ts['done_bytes'] +=3D len(backed_= +up)<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0 if backed_up !=3D live_data:<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return False<b= +r>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # check whether more data has= + been appended to the live data<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= +=A0 live_data =3D f.read(1)<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = +if live_data:<br>+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= +=A0=C2=A0 return False<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = +return True<br>=C2=A0<br>=C2=A0=C2=A0=C2=A0=C2=A0 def walk(self, gen_id, ar= +gs):<br>-- <br>1.9.1<br><br></div> + +--001a113441b028612c051011aded-- + + +--===============4839776383272810965== +Content-Type: text/plain; charset="us-ascii" +MIME-Version: 1.0 +Content-Transfer-Encoding: 7bit +Content-Disposition: inline + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org + +--===============4839776383272810965==-- + diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455999004.M693654P17339Q146.exolobe1 b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455999004.M693654P17339Q146.exolobe1 new file mode 100644 index 0000000..8ac4637 --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/new/1455999004.M693654P17339Q146.exolobe1 @@ -0,0 +1,115 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id A35B02C686 + for <distix@pieni.net>; Sat, 28 Feb 2015 18:49:59 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 645033588; + Sat, 28 Feb 2015 17:49:59 +0000 (GMT) +Received: from localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRlWZ-0000P2-9h; Sat, 28 Feb 2015 17:49:59 +0000 +Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YRlWY-0000OI-5E + for <obnam-dev@obnam.org>; Sat, 28 Feb 2015 17:49:58 +0000 +Received: from xvm-166-37.ghst.net + ([95.142.166.37] helo=pieni.net ident=postfix) + by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) + (Exim 4.80) (envelope-from <liw@liw.fi>) id 1YRlWV-0000ZB-Hp + for obnam-dev@obnam.org; Sat, 28 Feb 2015 17:49:58 +0000 +Received: from exolobe1.liw.fi (82-181-8-107.bb.dnainternet.fi [82.181.8.107]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPSA id 076492C686 + for <obnam-dev@obnam.org>; Sat, 28 Feb 2015 18:49:54 +0100 (CET) +Received: from exolobe1.liw.fi (localhost [127.0.0.1]) + by exolobe1.liw.fi (Postfix) with ESMTPS id 90EFA41329 + for <obnam-dev@obnam.org>; Sat, 28 Feb 2015 19:48:22 +0200 (EET) +Date: Sat, 28 Feb 2015 19:48:21 +0200 +From: Lars Wirzenius <liw@liw.fi> +To: obnam-dev@obnam.org +Message-ID: <20150228174821.GG2140@exolobe1.liw.fi> +References: <CAF+2JmHevknkwghCPN2YJVEUE-VYkN-b6rh4D=0KhWhBvqw+pg@mail.gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <CAF+2JmHevknkwghCPN2YJVEUE-VYkN-b6rh4D=0KhWhBvqw+pg@mail.gmail.com> +User-Agent: Mutt/1.5.23 (2014-03-12) +X-Spam-Score: -3.4 +X-Spam-Score-int: -33 +X-Spam-Bar: --- +X-Scanned-By: pepperfish.net, Sat, 28 Feb 2015 17:49:58 +0000 +X-Spam-Report: Content analysis details: (-3.4 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam + tool) -0.5 PPF_USER_AGENT User-Agent: exists + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +Subject: Re: [PATCH] verify_plugin: verify_chunks - consider case when live + file has grown +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +That's a nice bug, thank you for catching it. It would be really nice +to add a regression test for it in the yarn test suite. Could you do +that, please? The yarns/0080-verify.yarn file would be the right +place. If you'd rather I did that, please say so. + +On Fri, Feb 27, 2015 at 02:16:29PM +0100, Thomas Waldmann wrote: +> When the live file has new data appended at the end, the verification +> should fail. +> +> It previously did not, because it only compared the data up to the length +> of all backup data chunks (== the backupped file's length). +> --- +> obnamlib/plugins/verify_plugin.py | 4 ++++ +> 1 file changed, 4 insertions(+) +> +> diff --git a/obnamlib/plugins/verify_plugin.py +> b/obnamlib/plugins/verify_plugin.py +> index 50cd1d0..9e1ae7c 100644 +> --- a/obnamlib/plugins/verify_plugin.py +> +++ b/obnamlib/plugins/verify_plugin.py +> @@ -207,6 +207,10 @@ class VerifyPlugin(obnamlib.ObnamPlugin): +> self.app.ts['done_bytes'] += len(backed_up) +> if backed_up != live_data: +> return False +> + # check whether more data has been appended to the live data +> + live_data = f.read(1) +> + if live_data: +> + return False +> return True +> +> def walk(self, gen_id, args): +> -- +> 1.9.1 + +> _______________________________________________ +> obnam-dev mailing list +> obnam-dev@obnam.org +> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org + + +-- +Happiness is a tested backup. + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/tmp/.this-dir-not-empty/.empty/empty-file b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/tmp/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/Maildir/tmp/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/3979d2a6019547edaa6ebd332f80cc78/ticket.yaml b/tickets/3979d2a6019547edaa6ebd332f80cc78/ticket.yaml new file mode 100644 index 0000000..1546c98 --- /dev/null +++ b/tickets/3979d2a6019547edaa6ebd332f80cc78/ticket.yaml @@ -0,0 +1,4 @@ +ticket-id: +- 3979d2a6019547edaa6ebd332f80cc78 +title: +- "[PATCH] verify_plugin: verify_chunks - consider case when live file\n has grown" |