diff options
author | Lars Wirzenius <liw@liw.fi> | 2016-02-20 22:10:13 +0200 |
---|---|---|
committer | Lars Wirzenius <liw@liw.fi> | 2016-02-20 22:10:13 +0200 |
commit | 8c087e41fdda5d9508b9c95ea57fbd079142633d (patch) | |
tree | 44bbbcec3aac27d6ca26d498ac1b4f77ae15c190 /tickets/e21786a47a674589abdcee9b03f811da | |
parent | ea12bbd09cf9e03d4b50f139f55925aad10dcec0 (diff) | |
download | obnam-dev-distix-8c087e41fdda5d9508b9c95ea57fbd079142633d.tar.gz |
imported mails
Diffstat (limited to 'tickets/e21786a47a674589abdcee9b03f811da')
6 files changed, 324 insertions, 0 deletions
diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/cur/.this-dir-not-empty/.empty/empty-file b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/cur/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/cur/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/.this-dir-not-empty/.empty/empty-file b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M957879P17339Q138.exolobe1 b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M957879P17339Q138.exolobe1 new file mode 100644 index 0000000..2363b1c --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M957879P17339Q138.exolobe1 @@ -0,0 +1,160 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id A96F42329C + for <distix@pieni.net>; Fri, 6 Nov 2015 18:46:06 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 17433CE2; + Fri, 6 Nov 2015 17:46:06 +0000 (GMT) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1Zul5R-0004iQ-VW; Fri, 06 Nov 2015 17:46:06 +0000 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1Zul5Q-0004iH-FR + for <obnam-dev@obnam.org>; Fri, 06 Nov 2015 17:46:04 +0000 +Received: from mail-yk0-f178.google.com ([209.85.160.178]) + by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) + (Exim 4.80) (envelope-from <2bluesc@gmail.com>) id 1Zul5O-0004bP-6j + for obnam-dev@obnam.org; Fri, 06 Nov 2015 17:46:04 +0000 +Received: by ykek133 with SMTP id k133so191973447yke.2 + for <obnam-dev@obnam.org>; Fri, 06 Nov 2015 09:45:50 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:date:message-id:subject:from:to:content-type + :content-transfer-encoding; + bh=jkjBKKFu1dsjgCic1G5Vc2iO0ogsttjCsGNv5S1bEKY=; + b=NdoJiyg4bgFf5yjd6qFj95r0nwagnNIx+b99AJ69l4+DQc8yrlL1mxfQRem8vis5TU + s4Z9eaT43LimSUskZjvtk7chkN86t8d1RQ7U8LnCeGx/c4X0K4uUnCBeMrUst/WaeP0m + rz6y0BwMdXnFO90S0x/Rm6J4+2o9SVbJvGGQxR/+OH7/z8xNPVFqajSPkoWivZBWem+T + uqROz3L9gA8aJvZISvre6DyocNDzNGg7NgGUnDTJPCMp6APpjtrW19rIBX8XKkKWRHfP + U6HFHtR4B3gc22hAcFu69HEYJGbNcjZKmHAD13QS3kTeturJ8DMC3wIrp1+FjqiyGqBa + lr6Q== +MIME-Version: 1.0 +X-Received: by 10.129.72.151 with SMTP id v145mr13963080ywa.330.1446831949946; + Fri, 06 Nov 2015 09:45:49 -0800 (PST) +Received: by 10.129.113.133 with HTTP; Fri, 6 Nov 2015 09:45:49 -0800 (PST) +Date: Fri, 6 Nov 2015 09:45:49 -0800 +Message-ID: <CAM9fjH50TfjxaY9spb8tFgxGfpXJ2kyw93PpnGrPeNO4AL4wNA@mail.gmail.com> +From: Kyle Manna <2bluesc@gmail.com> +To: obnam-dev@obnam.org +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable +X-Spam-Score: 2.8 +X-Spam-Score-int: 28 +X-Spam-Bar: ++ +X-Scanned-By: pepperfish.net, Fri, 06 Nov 2015 17:46:04 +0000 +X-Spam-Report: Content analysis details: (2.8 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.5 PPF_RECEIVED_HTTP Received header mentions http + 1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail' + 1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider + (2bluesc[at]gmail.com) + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [209.85.160.178 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + 2.8 UNWANTED_LANGUAGE_BODY BODY: Message written in an undesired language + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] + -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's + domain + 0.1 DKIM_SIGNED Message has a DKIM or DK signature, + not necessarily valid + -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature +X-ACL-Warn: message may be spam +X-Scan-Signature: a02e829f6933b0f49c4716235214d89f +Subject: Paramiko 1.16 breaks obnam +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +After upgrading python2-paramiko (1.15.3-1 -> 1.16.0-1), the sftp lib crash= +es: + +Traceback (most recent call last): + File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 189, in _run + self.process_args(args) + File "/usr/lib/python2.7/site-packages/obnamlib/app.py", line 207, +in process_args + cliapp.Application.process_args(self, args) + File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 566, in +process_args + method(args[1:]) + File "/usr/lib/python2.7/site-packages/obnamlib/plugins/force_lock_plugin= +.py", +line 49, in force_lock + for client_name in repo.get_client_names(): + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_fmt_6.py", +line 154, in get_client_names + return self._client_list.list_clients() + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/clientlist.py", +line 78, in list_clients + if self.init_forest() and self.forest.trees: + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_tree.py", +line 63, in init_forest + allow_writes=3Dallow_writes) + File "/usr/lib/python2.7/site-packages/larch/forest.py", line 199, +in open_forest + check_size('key_size', key_size, BadKeySize) + File "/usr/lib/python2.7/site-packages/larch/forest.py", line 193, +in check_size + if keyname not in ns.get_metadata_keys(): + File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +line 167, in get_metadata_keys + self._load_metadata() + File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +line 148, in _load_metadata + data =3D self.journal.cat(self.metadata_name) + File "/usr/lib/python2.7/site-packages/larch/journal.py", line 162, in ca= +t + return self.fs.cat(filename) + File "/usr/lib/python2.7/site-packages/obnamlib/repo_fs.py", line 56, in = +cat + data =3D self.fs.cat(filename) + File "/usr/lib/python2.7/site-packages/obnamlib/plugins/sftp_plugin.py", +line 588, in cat + f.prefetch() +TypeError: prefetch() takes exactly 2 arguments (1 given) + + +Documentation confirms the added file size argument: +http://docs.paramiko.org/en/1.15/api/sftp.html +http://docs.paramiko.org/en/1.16/api/sftp.html + +Change that broke it: +https://github.com/paramiko/paramiko/commit/49072f3537a8981e9d448c22481a1d2= +b92c03643 + +My patch to fix this by prefetching the entire file: +https://gist.github.com/kylemanna/cc951490b992050f86ac + +--- a/obnamlib/plugins/sftp_plugin.py ++++ b/obnamlib/plugins/sftp_plugin.py +@@ -555,7 +555,7 @@ class SftpFS(obnamlib.VirtualFileSystem): +def cat(self, pathname): +self._delay() +f =3D self.open(pathname, 'rb') +- f.prefetch() ++ f.prefetch(self.lstat(pathname).st_size) +chunks =3D [] +while True: +chunk =3D f.read(self.chunk_size) +=E1=90=A7 + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M984651P17339Q139.exolobe1 b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M984651P17339Q139.exolobe1 new file mode 100644 index 0000000..2363b1c --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1455999003.M984651P17339Q139.exolobe1 @@ -0,0 +1,160 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id A96F42329C + for <distix@pieni.net>; Fri, 6 Nov 2015 18:46:06 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id 17433CE2; + Fri, 6 Nov 2015 17:46:06 +0000 (GMT) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1Zul5R-0004iQ-VW; Fri, 06 Nov 2015 17:46:06 +0000 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1Zul5Q-0004iH-FR + for <obnam-dev@obnam.org>; Fri, 06 Nov 2015 17:46:04 +0000 +Received: from mail-yk0-f178.google.com ([209.85.160.178]) + by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) + (Exim 4.80) (envelope-from <2bluesc@gmail.com>) id 1Zul5O-0004bP-6j + for obnam-dev@obnam.org; Fri, 06 Nov 2015 17:46:04 +0000 +Received: by ykek133 with SMTP id k133so191973447yke.2 + for <obnam-dev@obnam.org>; Fri, 06 Nov 2015 09:45:50 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:date:message-id:subject:from:to:content-type + :content-transfer-encoding; + bh=jkjBKKFu1dsjgCic1G5Vc2iO0ogsttjCsGNv5S1bEKY=; + b=NdoJiyg4bgFf5yjd6qFj95r0nwagnNIx+b99AJ69l4+DQc8yrlL1mxfQRem8vis5TU + s4Z9eaT43LimSUskZjvtk7chkN86t8d1RQ7U8LnCeGx/c4X0K4uUnCBeMrUst/WaeP0m + rz6y0BwMdXnFO90S0x/Rm6J4+2o9SVbJvGGQxR/+OH7/z8xNPVFqajSPkoWivZBWem+T + uqROz3L9gA8aJvZISvre6DyocNDzNGg7NgGUnDTJPCMp6APpjtrW19rIBX8XKkKWRHfP + U6HFHtR4B3gc22hAcFu69HEYJGbNcjZKmHAD13QS3kTeturJ8DMC3wIrp1+FjqiyGqBa + lr6Q== +MIME-Version: 1.0 +X-Received: by 10.129.72.151 with SMTP id v145mr13963080ywa.330.1446831949946; + Fri, 06 Nov 2015 09:45:49 -0800 (PST) +Received: by 10.129.113.133 with HTTP; Fri, 6 Nov 2015 09:45:49 -0800 (PST) +Date: Fri, 6 Nov 2015 09:45:49 -0800 +Message-ID: <CAM9fjH50TfjxaY9spb8tFgxGfpXJ2kyw93PpnGrPeNO4AL4wNA@mail.gmail.com> +From: Kyle Manna <2bluesc@gmail.com> +To: obnam-dev@obnam.org +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable +X-Spam-Score: 2.8 +X-Spam-Score-int: 28 +X-Spam-Bar: ++ +X-Scanned-By: pepperfish.net, Fri, 06 Nov 2015 17:46:04 +0000 +X-Spam-Report: Content analysis details: (2.8 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + 0.5 PPF_RECEIVED_HTTP Received header mentions http + 1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail' + 1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider + (2bluesc[at]gmail.com) + -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low + trust [209.85.160.178 listed in list.dnswl.org] + -0.0 SPF_PASS SPF: sender matches SPF record + 2.8 UNWANTED_LANGUAGE_BODY BODY: Message written in an undesired language + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] + -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's + domain + 0.1 DKIM_SIGNED Message has a DKIM or DK signature, + not necessarily valid + -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature +X-ACL-Warn: message may be spam +X-Scan-Signature: a02e829f6933b0f49c4716235214d89f +Subject: Paramiko 1.16 breaks obnam +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +After upgrading python2-paramiko (1.15.3-1 -> 1.16.0-1), the sftp lib crash= +es: + +Traceback (most recent call last): + File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 189, in _run + self.process_args(args) + File "/usr/lib/python2.7/site-packages/obnamlib/app.py", line 207, +in process_args + cliapp.Application.process_args(self, args) + File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 566, in +process_args + method(args[1:]) + File "/usr/lib/python2.7/site-packages/obnamlib/plugins/force_lock_plugin= +.py", +line 49, in force_lock + for client_name in repo.get_client_names(): + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_fmt_6.py", +line 154, in get_client_names + return self._client_list.list_clients() + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/clientlist.py", +line 78, in list_clients + if self.init_forest() and self.forest.trees: + File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_tree.py", +line 63, in init_forest + allow_writes=3Dallow_writes) + File "/usr/lib/python2.7/site-packages/larch/forest.py", line 199, +in open_forest + check_size('key_size', key_size, BadKeySize) + File "/usr/lib/python2.7/site-packages/larch/forest.py", line 193, +in check_size + if keyname not in ns.get_metadata_keys(): + File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +line 167, in get_metadata_keys + self._load_metadata() + File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +line 148, in _load_metadata + data =3D self.journal.cat(self.metadata_name) + File "/usr/lib/python2.7/site-packages/larch/journal.py", line 162, in ca= +t + return self.fs.cat(filename) + File "/usr/lib/python2.7/site-packages/obnamlib/repo_fs.py", line 56, in = +cat + data =3D self.fs.cat(filename) + File "/usr/lib/python2.7/site-packages/obnamlib/plugins/sftp_plugin.py", +line 588, in cat + f.prefetch() +TypeError: prefetch() takes exactly 2 arguments (1 given) + + +Documentation confirms the added file size argument: +http://docs.paramiko.org/en/1.15/api/sftp.html +http://docs.paramiko.org/en/1.16/api/sftp.html + +Change that broke it: +https://github.com/paramiko/paramiko/commit/49072f3537a8981e9d448c22481a1d2= +b92c03643 + +My patch to fix this by prefetching the entire file: +https://gist.github.com/kylemanna/cc951490b992050f86ac + +--- a/obnamlib/plugins/sftp_plugin.py ++++ b/obnamlib/plugins/sftp_plugin.py +@@ -555,7 +555,7 @@ class SftpFS(obnamlib.VirtualFileSystem): +def cat(self, pathname): +self._delay() +f =3D self.open(pathname, 'rb') +- f.prefetch() ++ f.prefetch(self.lstat(pathname).st_size) +chunks =3D [] +while True: +chunk =3D f.read(self.chunk_size) +=E1=90=A7 + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/tmp/.this-dir-not-empty/.empty/empty-file b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/tmp/.this-dir-not-empty/.empty/empty-file new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/tmp/.this-dir-not-empty/.empty/empty-file diff --git a/tickets/e21786a47a674589abdcee9b03f811da/ticket.yaml b/tickets/e21786a47a674589abdcee9b03f811da/ticket.yaml new file mode 100644 index 0000000..c45d464 --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/ticket.yaml @@ -0,0 +1,4 @@ +ticket-id: +- e21786a47a674589abdcee9b03f811da +title: +- Paramiko 1.16 breaks obnam |