diff options
Diffstat (limited to 'tickets/4699a692d46f4fde9da42a943bc81ae2/Maildir/new/1455999010.M505373P17339Q207.exolobe1')
| -rw-r--r-- | tickets/4699a692d46f4fde9da42a943bc81ae2/Maildir/new/1455999010.M505373P17339Q207.exolobe1 | 138 |
1 files changed, 138 insertions, 0 deletions
diff --git a/tickets/4699a692d46f4fde9da42a943bc81ae2/Maildir/new/1455999010.M505373P17339Q207.exolobe1 b/tickets/4699a692d46f4fde9da42a943bc81ae2/Maildir/new/1455999010.M505373P17339Q207.exolobe1 new file mode 100644 index 0000000..e0a0560 --- /dev/null +++ b/tickets/4699a692d46f4fde9da42a943bc81ae2/Maildir/new/1455999010.M505373P17339Q207.exolobe1 @@ -0,0 +1,138 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 584392C1EA + for <distix@pieni.net>; Thu, 26 Feb 2015 22:46:50 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id DAF3C351E; + Thu, 26 Feb 2015 21:46:49 +0000 (GMT) +Received: from localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YR6Gf-0007YI-PZ; Thu, 26 Feb 2015 21:46:49 +0000 +Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1YR6Ge-0007Y8-9k + for <obnam-dev@obnam.org>; Thu, 26 Feb 2015 21:46:48 +0000 +Received: from xvm-166-37.ghst.net + ([95.142.166.37] helo=pieni.net ident=postfix) + by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) + (Exim 4.80) (envelope-from <liw@liw.fi>) id 1YR6Gb-0007FE-Fh + for obnam-dev@obnam.org; Thu, 26 Feb 2015 21:46:48 +0000 +Received: from exolobe1.liw.fi (82-181-8-107.bb.dnainternet.fi [82.181.8.107]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPSA id 413C42C1EA; + Thu, 26 Feb 2015 22:46:42 +0100 (CET) +Received: from exolobe1.liw.fi (localhost [127.0.0.1]) + by exolobe1.liw.fi (Postfix) with ESMTPS id B455141329; + Thu, 26 Feb 2015 23:45:12 +0200 (EET) +Date: Thu, 26 Feb 2015 23:45:11 +0200 +From: Lars Wirzenius <liw@liw.fi> +To: Thomas Waldmann <thomas.j.waldmann@gmail.com> +Message-ID: <20150226214511.GD2140@exolobe1.liw.fi> +References: <CAF+2JmFGrzWSrEya2pUisT-dWDeeNTsPoBhXt47y3B9DJdwwDA@mail.gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <CAF+2JmFGrzWSrEya2pUisT-dWDeeNTsPoBhXt47y3B9DJdwwDA@mail.gmail.com> +User-Agent: Mutt/1.5.23 (2014-03-12) +X-Spam-Score: -3.4 +X-Spam-Score-int: -33 +X-Spam-Bar: --- +X-Scanned-By: pepperfish.net, Thu, 26 Feb 2015 21:46:48 +0000 +X-Spam-Report: Content analysis details: (-3.4 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam + tool) -0.5 PPF_USER_AGENT User-Agent: exists + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +Cc: obnam-dev@obnam.org +Subject: Re: PATCH: minor style fixes, no functional change +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + +Thank you, applied and pushed. + +On Thu, Feb 26, 2015 at 10:42:41AM +0100, Thomas Waldmann wrote: +> Some stuff found by pycharm code checker. +> +> --- +> obnamlib/metadata_tests.py | 6 +++--- +> obnamlib/plugins/show_plugin.py | 2 +- +> 2 files changed, 4 insertions(+), 4 deletions(-) +> +> diff --git a/obnamlib/metadata_tests.py b/obnamlib/metadata_tests.py +> index efb01b3..98fbebe 100644 +> --- a/obnamlib/metadata_tests.py +> +++ b/obnamlib/metadata_tests.py +> @@ -145,7 +145,7 @@ class ReadMetadataTests(unittest.TestCase): +> field) +> +> def test_returns_symlink_fields_correctly(self): +> - self.fakefs.st_mode |= stat.S_IFLNK; +> + self.fakefs.st_mode |= stat.S_IFLNK +> metadata = obnamlib.read_metadata(self.fakefs, 'foo', +> getpwuid=self.fakefs.getpwuid, +> getgrgid=self.fakefs.getgrgid) +> @@ -253,14 +253,14 @@ class SetMetadataTests(unittest.TestCase): +> +> def test_sets_symlink_target(self): +> self.fs.remove(self.filename) +> - self.metadata.st_mode = 0777 | stat.S_IFLNK; +> + self.metadata.st_mode = 0777 | stat.S_IFLNK +> self.metadata.target = 'target' +> obnamlib.set_metadata(self.fs, self.filename, self.metadata) +> self.assertEqual(self.fs.readlink(self.filename), 'target') +> +> def test_sets_symlink_mtime_perms(self): +> self.fs.remove(self.filename) +> - self.metadata.st_mode = 0777 | stat.S_IFLNK; +> + self.metadata.st_mode = 0777 | stat.S_IFLNK +> self.metadata.target = 'target' +> obnamlib.set_metadata(self.fs, self.filename, self.metadata) +> st = os.lstat(self.filename) +> diff --git a/obnamlib/plugins/show_plugin.py +> b/obnamlib/plugins/show_plugin.py +> index 5e28fed..00d478d 100644 +> --- a/obnamlib/plugins/show_plugin.py +> +++ b/obnamlib/plugins/show_plugin.py +> @@ -467,7 +467,7 @@ class ShowPlugin(obnamlib.ObnamPlugin): +> if unit is None: unit = default_unit +> +> if unit == 's': +> - None +> + pass +> elif unit == 'm': +> ticks *= 60 +> elif unit == 'h': +> -- +> 1.9.1 + +> _______________________________________________ +> obnam-dev mailing list +> obnam-dev@obnam.org +> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org + + +-- +Happiness is a tested backup. + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org |