1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 9B12523520
for <distix@pieni.net>; Sun, 20 Dec 2015 15:16:46 +0100 (CET)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id EC9E3B71;
Sun, 20 Dec 2015 14:16:45 +0000 (GMT)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1aAemz-0005Xk-Nv; Sun, 20 Dec 2015 14:16:45 +0000
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1aAemy-0005Xb-TR
for <obnam-dev@obnam.org>; Sun, 20 Dec 2015 14:16:44 +0000
Received: from pieni.net ([95.142.166.37] ident=postfix)
by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80) (envelope-from <liw@liw.fi>) id 1aAemw-0001oT-VW
for obnam-dev@obnam.org; Sun, 20 Dec 2015 14:16:44 +0000
Received: from exolobe1.liw.fi (unknown [82.129.76.156])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPSA id 5E09823264;
Sun, 20 Dec 2015 15:16:35 +0100 (CET)
Received: from exolobe1.liw.fi (localhost [127.0.0.1])
by exolobe1.liw.fi (Postfix) with ESMTPS id B128C41391;
Sun, 20 Dec 2015 15:16:34 +0100 (CET)
Date: Sun, 20 Dec 2015 15:16:33 +0100
From: Lars Wirzenius <liw@liw.fi>
To: Ben Boeckel <mathstuf@gmail.com>
Message-ID: <20151220141633.GE2511@exolobe1.liw.fi>
References: <20150918050247.GA8128@bronto-burt.dev.benboeckel.net>
<1446094196-14166-1-git-send-email-mathstuf@gmail.com>
<20151029045526.GA13909@bronto-burt.dev.benboeckel.net>
MIME-Version: 1.0
In-Reply-To: <20151029045526.GA13909@bronto-burt.dev.benboeckel.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -3.4
X-Spam-Score-int: -33
X-Spam-Bar: ---
X-Scanned-By: pepperfish.net, Sun, 20 Dec 2015 14:16:44 +0000
X-Spam-Report: Content analysis details: (-3.4 points)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam
tool) -0.5 PPF_USER_AGENT User-Agent: exists
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-ACL-Warn: message may be spam
X-Scan-Signature: f11bba8f41b8bc2894d5c90ad7eebf09
Cc: obnam-dev@obnam.org
Subject: Re: [PATCH] backup: take an inhibitor lock if possible
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============4837920643194033257=="
Mime-version: 1.0
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
--===============4837920643194033257==
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="SWTRyWv/ijrBap1m"
Content-Disposition: inline
--SWTRyWv/ijrBap1m
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi, sorry, it's been a month and a half since this patch.
On Thu, Oct 29, 2015 at 12:55:26AM -0400, Ben Boeckel wrote:
> On Thu, Oct 29, 2015 at 00:49:56 -0400, Ben Boeckel wrote:
> > When a backup is happening, the machine should not suspend or otherwise
> > go down. Add a setting for taking a systemd inhibitor lock.
> >=20
> > The code fails safely which allows both the dbus module and the
> > systemd-logind DBus interface to be optional. In both cases, warnings
> > are generated.
>=20
> So, I'm not really sure how to test this properly within the test suite;
> the lock is really kind of opaque without running systemd-inhibit to
> list the active locks. Manual testing shows that obnam is taking the
> inhibitor lock (with the proper description and all) as seen with
> `systemd-inhibit --list`. Can anyone without systemd and/or dbus verify
> the "fails gracefully" bit? I don't have any testing machines with obnam
> and without those bits.
I'm not entirely sure I'm comfortable adding this kind of code to
Obnam. I think it'd be better off as a separate utility, kind of like
the flock utility. It could be used like this:
inhibit-suspend obnam backup
Such a utility would be more generic than code specifically in Obnam.
So I'm afraid I'm going to reject the patch.
--=20
Schr=F6dinger's backup hypothesis: the condition of any backup is
undefined until a restore is attempted. -- andrewsh
--SWTRyWv/ijrBap1m
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJWdrhBAAoJEGwvphbseiAx9LQP/1YI0XDbJXecTlBjHx1Dop52
cBVHZjrPyRrZZRQ0ymY66w1687S7pmTFi0DVR1XPecVXHZ2fxLBmf3Z7ukcHjr5e
frnPbXMs1qhRs6Ou3hhlRZ5HA+vuFZ2B20WDEGc8l229xe3q6pu0F+rSkRZ23iur
fWbSzMSaQNoOP8fkjJ6/ifR0j1TTWhsYCcO0DN/jQ0rWbGUPFeisZpS8UMxZ1Apm
dorrzozGYPfck6/ZNFNv6d885xPrtZStjg59e1n4/De+0vI/EKHc5YfP+2eSsJPh
7ya9kZPl22z5fUPfOKJBLFJfvXVaSSIKLYrHdLndiO5tPcJhZESgbli4QgfjCBIf
v2Ut2a4tSMFJ+EECOR759c8UOR0yaS8Du8D/Qv5voYsI7v+WG9PqnOgDq+fmM5/h
p4OipXN9GQLE07S/ohMwLbopEVkRg6pVLNtLcLv01rfp42TINQGZQQR5xAluxks+
m2ZO7Ix0qZozy3Ci7oxDro9LjR4WDsbQvthah70feLxaIb0Ly6gmQeqNrTlES/mQ
C7Pm+oexgvojLkEFoQdRrol+KErYxHWGs04dBms6AC19o1BWSJVXl9Rqm2c/Xzf+
2/iNT3sBsq2rCgnEe+9BsZxwhoPhWNFd6wTfKtyIB1/6ZUoMDPHx0Lg2O2gzbCA/
rP24EpJSUkKtRAUlxPoJ
=YDWI
-----END PGP SIGNATURE-----
--SWTRyWv/ijrBap1m--
--===============4837920643194033257==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
--===============4837920643194033257==--
|
