1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 8E8532CE13
for <distix@pieni.net>; Mon, 2 Feb 2015 19:05:36 +0100 (CET)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id B3F433374;
Mon, 2 Feb 2015 18:05:35 +0000 (GMT)
Received: from localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1YILNP-0005jZ-IR; Mon, 02 Feb 2015 18:05:35 +0000
Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1YILNO-0005jT-7s
for <obnam-dev@obnam.org>; Mon, 02 Feb 2015 18:05:34 +0000
Received: from xvm-166-37.ghst.net
([95.142.166.37] helo=pieni.net ident=postfix)
by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80) (envelope-from <liw@liw.fi>) id 1YILNL-0005uP-Kd
for obnam-dev@obnam.org; Mon, 02 Feb 2015 18:05:34 +0000
Received: from exolobe1.liw.fi (82-181-8-107.bb.dnainternet.fi [82.181.8.107])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPSA id C86CB2CE13
for <obnam-dev@obnam.org>; Mon, 2 Feb 2015 19:05:29 +0100 (CET)
Received: from exolobe1.liw.fi (localhost [127.0.0.1])
by exolobe1.liw.fi (Postfix) with ESMTPS id C095E4111F
for <obnam-dev@obnam.org>; Mon, 2 Feb 2015 20:04:51 +0200 (EET)
Date: Mon, 2 Feb 2015 20:04:50 +0200
From: Lars Wirzenius <liw@liw.fi>
To: obnam-dev@obnam.org
Message-ID: <20150202180450.GG31560@exolobe1.liw.fi>
References: <1422891564-20648-1-git-send-email-jn@hz6.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422891564-20648-1-git-send-email-jn@hz6.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -3.4
X-Spam-Score-int: -33
X-Spam-Bar: ---
X-Scanned-By: pepperfish.net, Mon, 02 Feb 2015 18:05:34 +0000
X-Spam-Report: Content analysis details: (-3.4 points)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam
tool) -0.5 PPF_USER_AGENT User-Agent: exists
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
Subject: Re: [PATCH] adds fr to clean target
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
On Mon, Feb 02, 2015 at 04:39:24PM +0100, Jan Niggemann wrote:
> Also prepends the targets with a minus sign to continue even if a target fails
> (http://www.cprogramming.com/tutorial/makefiles.html)
I'm going to reject that part of the patch. It's bad practice to
prepend the minus sign to rm commands to avoid them failing when the
file being removed doesn't exist. The prepended minus tells Make to
ignore _any_ failure, including failure because an option is wrong, or
the command doesn't exist. In those cases, you _want_ the command to
fail and Make to stop executing any more commands, 'cause the rule
wasn't doing what you thought it was doing.
The -f option to rm already makes rm not fail even if any of the files
it is told to remove are missing. The prepended minus in the Makefile
does nothing useful here.
Sorry, a bit of a rant: this is one of my pet peeves with the way
people write Makefiles (or tutorials for Make).
I'm happy to merge a simpler patch that just adds fr. (Though, some
day, I will get rid of clean targets in my Makefiles and just use git
clean.)
--
Happiness is a tested backup.
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
|
