1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 908872C383
for <distix@pieni.net>; Thu, 26 Feb 2015 10:43:09 +0100 (CET)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id EABC829D3;
Thu, 26 Feb 2015 09:43:08 +0000 (GMT)
Received: from localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1YQuyK-0007kL-RP; Thu, 26 Feb 2015 09:43:08 +0000
Received: from inmail ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1YQuyJ-0007ip-8w
for <obnam-dev@obnam.org>; Thu, 26 Feb 2015 09:43:07 +0000
Received: from mail-pa0-f44.google.com ([209.85.220.44])
by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128)
(Exim 4.80) (envelope-from <thomas.j.waldmann@gmail.com>)
id 1YQuy1-0001EW-7C
for obnam-dev@obnam.org; Thu, 26 Feb 2015 09:43:07 +0000
Received: by pablj1 with SMTP id lj1so10294532pab.9
for <obnam-dev@obnam.org>; Thu, 26 Feb 2015 01:42:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=mime-version:date:message-id:subject:from:to:content-type;
bh=rSI2fzzktY7EyPtb1twmK9TmVoW0BpI7NNFFLHaYkBg=;
b=lExHIT7oFBL/B2dP9yJYkU9Vs8dt+LTV/UvH7opb36PDkn6vT6DdSMsG3Dgo3GDxnl
zlvTXowh95I1SCr5lYjKR9BqjbK/YLaCPu0fYgxk44SOqaJYjE0tE1Gf+DviiLTjnY64
iB3HbdakWEOHuI0rbiu2qBWthNKfraIkof1zQ2LvrULuWxy/Kbfxv5kR75o56na6jIyO
4H0fbCoNX53XZvu3oI595e0kAJkKnEhYJCbXlLJC6oweS2+toYeJKFWERbzooMdp/vP4
G9O82Qhoyzwp7H1rKgdhtq0KHILu4aZbJQ3leY7GiXJmiLegT9AF/+qDKmioO6hotRS/
PP7Q==
MIME-Version: 1.0
X-Received: by 10.68.203.166 with SMTP id kr6mr13498726pbc.92.1424943761502;
Thu, 26 Feb 2015 01:42:41 -0800 (PST)
Received: by 10.66.185.45 with HTTP; Thu, 26 Feb 2015 01:42:41 -0800 (PST)
Date: Thu, 26 Feb 2015 10:42:41 +0100
Message-ID: <CAF+2JmFGrzWSrEya2pUisT-dWDeeNTsPoBhXt47y3B9DJdwwDA@mail.gmail.com>
From: Thomas Waldmann <thomas.j.waldmann@gmail.com>
To: obnam-dev@obnam.org
X-Spam-Score: 0.7
X-Spam-Score-int: 7
X-Spam-Bar: /
X-Scanned-By: pepperfish.net, Thu, 26 Feb 2015 09:42:51 +0000
X-Spam-Report: Content analysis details: (0.7 points)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 PPF_ALTERNATIVES Body in multipart/alternative
0.5 PPF_RECEIVED_HTTP Received header mentions http
1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail'
1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(thomas.j.waldmann[at]gmail.com)
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust [209.85.220.44 listed in list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
0.3 HTML_MESSAGE BODY: HTML included in message
0.2 PPF_NUMERIC_ENTITY RAW: Body contains numeric HTML entities
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
Subject: PATCH: minor style fixes, no functional change
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============6763714181841471609=="
Mime-version: 1.0
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
--===============6763714181841471609==
Content-Type: multipart/alternative; boundary=e89a8ffbae47bab8ce050ffa92ac
--e89a8ffbae47bab8ce050ffa92ac
Content-Type: text/plain; charset=UTF-8
Some stuff found by pycharm code checker.
---
obnamlib/metadata_tests.py | 6 +++---
obnamlib/plugins/show_plugin.py | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/obnamlib/metadata_tests.py b/obnamlib/metadata_tests.py
index efb01b3..98fbebe 100644
--- a/obnamlib/metadata_tests.py
+++ b/obnamlib/metadata_tests.py
@@ -145,7 +145,7 @@ class ReadMetadataTests(unittest.TestCase):
field)
def test_returns_symlink_fields_correctly(self):
- self.fakefs.st_mode |= stat.S_IFLNK;
+ self.fakefs.st_mode |= stat.S_IFLNK
metadata = obnamlib.read_metadata(self.fakefs, 'foo',
getpwuid=self.fakefs.getpwuid,
getgrgid=self.fakefs.getgrgid)
@@ -253,14 +253,14 @@ class SetMetadataTests(unittest.TestCase):
def test_sets_symlink_target(self):
self.fs.remove(self.filename)
- self.metadata.st_mode = 0777 | stat.S_IFLNK;
+ self.metadata.st_mode = 0777 | stat.S_IFLNK
self.metadata.target = 'target'
obnamlib.set_metadata(self.fs, self.filename, self.metadata)
self.assertEqual(self.fs.readlink(self.filename), 'target')
def test_sets_symlink_mtime_perms(self):
self.fs.remove(self.filename)
- self.metadata.st_mode = 0777 | stat.S_IFLNK;
+ self.metadata.st_mode = 0777 | stat.S_IFLNK
self.metadata.target = 'target'
obnamlib.set_metadata(self.fs, self.filename, self.metadata)
st = os.lstat(self.filename)
diff --git a/obnamlib/plugins/show_plugin.py
b/obnamlib/plugins/show_plugin.py
index 5e28fed..00d478d 100644
--- a/obnamlib/plugins/show_plugin.py
+++ b/obnamlib/plugins/show_plugin.py
@@ -467,7 +467,7 @@ class ShowPlugin(obnamlib.ObnamPlugin):
if unit is None: unit = default_unit
if unit == 's':
- None
+ pass
elif unit == 'm':
ticks *= 60
elif unit == 'h':
--
1.9.1
--e89a8ffbae47bab8ce050ffa92ac
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: base64
PGRpdiBkaXI9Imx0ciI+U29tZSBzdHVmZiBmb3VuZCBieSBweWNoYXJtIGNvZGUgY2hlY2tlci48
YnI+PGJyPjxkaXY+LS0tPGJyPsKgb2JuYW1saWIvbWV0YWRhdGFfdGVzdHMucHnCoMKgwqDCoMKg
IHwgNiArKystLS08YnI+wqBvYm5hbWxpYi9wbHVnaW5zL3Nob3dfcGx1Z2luLnB5IHwgMiArLTxi
cj7CoDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKTxicj48
YnI+ZGlmZiAtLWdpdCBhL29ibmFtbGliL21ldGFkYXRhX3Rlc3RzLnB5IGIvb2JuYW1saWIvbWV0
YWRhdGFfdGVzdHMucHk8YnI+aW5kZXggZWZiMDFiMy4uOThmYmViZSAxMDA2NDQ8YnI+LS0tIGEv
b2JuYW1saWIvbWV0YWRhdGFfdGVzdHMucHk8YnI+KysrIGIvb2JuYW1saWIvbWV0YWRhdGFfdGVz
dHMucHk8YnI+QEAgLTE0NSw3ICsxNDUsNyBAQCBjbGFzcyBSZWFkTWV0YWRhdGFUZXN0cyh1bml0
dGVzdC5UZXN0Q2FzZSk6PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgZmllbGQpPGJyPsKgPGJyPsKgwqDCoMKgIGRlZiB0ZXN0X3Jl
dHVybnNfc3ltbGlua19maWVsZHNfY29ycmVjdGx5KHNlbGYpOjxicj4twqDCoMKgwqDCoMKgwqAg
c2VsZi5mYWtlZnMuc3RfbW9kZSB8PSBzdGF0LlNfSUZMTks7PGJyPivCoMKgwqDCoMKgwqDCoCBz
ZWxmLmZha2Vmcy5zdF9tb2RlIHw9IHN0YXQuU19JRkxOSzxicj7CoMKgwqDCoMKgwqDCoMKgIG1l
dGFkYXRhID0gb2JuYW1saWIucmVhZF9tZXRhZGF0YShzZWxmLmZha2VmcywgJiMzOTtmb28mIzM5
Oyw8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdldHB3dWlkPXNlbGYuZmFrZWZzLmdl
dHB3dWlkLDxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2V0Z3JnaWQ9c2VsZi5mYWtl
ZnMuZ2V0Z3JnaWQpPGJyPkBAIC0yNTMsMTQgKzI1MywxNCBAQCBjbGFzcyBTZXRNZXRhZGF0YVRl
c3RzKHVuaXR0ZXN0LlRlc3RDYXNlKTo8YnI+wqA8YnI+wqDCoMKgwqAgZGVmIHRlc3Rfc2V0c19z
eW1saW5rX3RhcmdldChzZWxmKTo8YnI+wqDCoMKgwqDCoMKgwqDCoCBzZWxmLmZzLnJlbW92ZShz
ZWxmLmZpbGVuYW1lKTxicj4twqDCoMKgwqDCoMKgwqAgc2VsZi5tZXRhZGF0YS5zdF9tb2RlID0g
MDc3NyB8IHN0YXQuU19JRkxOSzs8YnI+K8KgwqDCoMKgwqDCoMKgIHNlbGYubWV0YWRhdGEuc3Rf
bW9kZSA9IDA3NzcgfCBzdGF0LlNfSUZMTks8YnI+wqDCoMKgwqDCoMKgwqDCoCBzZWxmLm1ldGFk
YXRhLnRhcmdldCA9ICYjMzk7dGFyZ2V0JiMzOTs8YnI+wqDCoMKgwqDCoMKgwqDCoCBvYm5hbWxp
Yi5zZXRfbWV0YWRhdGEoc2VsZi5mcywgc2VsZi5maWxlbmFtZSwgc2VsZi5tZXRhZGF0YSk8YnI+
wqDCoMKgwqDCoMKgwqDCoCBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZnMucmVhZGxpbmsoc2VsZi5m
aWxlbmFtZSksICYjMzk7dGFyZ2V0JiMzOTspPGJyPsKgPGJyPsKgwqDCoMKgIGRlZiB0ZXN0X3Nl
dHNfc3ltbGlua19tdGltZV9wZXJtcyhzZWxmKTo8YnI+wqDCoMKgwqDCoMKgwqDCoCBzZWxmLmZz
LnJlbW92ZShzZWxmLmZpbGVuYW1lKTxicj4twqDCoMKgwqDCoMKgwqAgc2VsZi5tZXRhZGF0YS5z
dF9tb2RlID0gMDc3NyB8IHN0YXQuU19JRkxOSzs8YnI+K8KgwqDCoMKgwqDCoMKgIHNlbGYubWV0
YWRhdGEuc3RfbW9kZSA9IDA3NzcgfCBzdGF0LlNfSUZMTks8YnI+wqDCoMKgwqDCoMKgwqDCoCBz
ZWxmLm1ldGFkYXRhLnRhcmdldCA9ICYjMzk7dGFyZ2V0JiMzOTs8YnI+wqDCoMKgwqDCoMKgwqDC
oCBvYm5hbWxpYi5zZXRfbWV0YWRhdGEoc2VsZi5mcywgc2VsZi5maWxlbmFtZSwgc2VsZi5tZXRh
ZGF0YSk8YnI+wqDCoMKgwqDCoMKgwqDCoCBzdCA9IG9zLmxzdGF0KHNlbGYuZmlsZW5hbWUpPGJy
PmRpZmYgLS1naXQgYS9vYm5hbWxpYi9wbHVnaW5zL3Nob3dfcGx1Z2luLnB5IGIvb2JuYW1saWIv
cGx1Z2lucy9zaG93X3BsdWdpbi5weTxicj5pbmRleCA1ZTI4ZmVkLi4wMGQ0NzhkIDEwMDY0NDxi
cj4tLS0gYS9vYm5hbWxpYi9wbHVnaW5zL3Nob3dfcGx1Z2luLnB5PGJyPisrKyBiL29ibmFtbGli
L3BsdWdpbnMvc2hvd19wbHVnaW4ucHk8YnI+QEAgLTQ2Nyw3ICs0NjcsNyBAQCBjbGFzcyBTaG93
UGx1Z2luKG9ibmFtbGliLk9ibmFtUGx1Z2luKTo8YnI+wqDCoMKgwqDCoMKgwqDCoCBpZiB1bml0
IGlzIE5vbmU6IHVuaXQgPSBkZWZhdWx0X3VuaXQ8YnI+wqA8YnI+wqDCoMKgwqDCoMKgwqDCoCBp
ZiB1bml0ID09ICYjMzk7cyYjMzk7Ojxicj4twqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBOb25lPGJy
PivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBhc3M8YnI+wqDCoMKgwqDCoMKgwqDCoCBlbGlmIHVu
aXQgPT0gJiMzOTttJiMzOTs6PGJyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB0aWNrcyAqPSA2
MDxicj7CoMKgwqDCoMKgwqDCoMKgIGVsaWYgdW5pdCA9PSAmIzM5O2gmIzM5Ozo8YnI+LS0gPGJy
PjEuOS4xPGJyPjxicj48L2Rpdj48L2Rpdj4NCg==
--e89a8ffbae47bab8ce050ffa92ac--
--===============6763714181841471609==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
--===============6763714181841471609==--
|
