1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 7D2CA2F907
for <distix@pieni.net>; Tue, 15 Mar 2016 16:33:24 +0100 (CET)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id 2A775F09;
Tue, 15 Mar 2016 15:33:24 +0000 (GMT)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1afqyK-0004LL-2D; Tue, 15 Mar 2016 15:33:24 +0000
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1afqyI-0004LD-3M
for <obnam-dev@obnam.org>; Tue, 15 Mar 2016 15:33:22 +0000
Received: from mail-qg0-f49.google.com ([209.85.192.49])
by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128)
(Exim 4.80) (envelope-from <remirampin@gmail.com>)
id 1afqyG-0002gq-5g
for obnam-dev@obnam.org; Tue, 15 Mar 2016 15:33:21 +0000
Received: by mail-qg0-f49.google.com with SMTP id w104so17424283qge.1
for <obnam-dev@obnam.org>; Tue, 15 Mar 2016 08:33:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=from:to:cc:subject:date:message-id:in-reply-to:references;
bh=OSmDwJHa3lFIa7zMOLbUtw0GPmkBUlA6N06xdOAlF0w=;
b=0YoRMVtl3/ggDwTobASEQcZOviaCsphazSJXgI3Da9B+p4h22Fzew9CTkvZVneRk0P
Us09s63+2rmB3EfI+AnFuO5MY2bEuhSzklAb3aYfbC5Rl7L8ZBDNcHiZQGwOC87hXowo
yTYvJdVn0im/7N99JkazlXWaaJqha10CSQx9V+Deuviu55gEokyCYDcn7/HHH5NgsCWi
ZZqzCct1RBFDsSeTKuAOrsbU8k0VNhWw7c9INebwyVyLTdlfAo3RchJhOzIsoZrvigTP
oSsvG3GfAIlDoCMO2tDFEukxlFo3bg6FHUCB4NSimResMs1DwXW3jUqvExXk8Api7ZkF
FdRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=OSmDwJHa3lFIa7zMOLbUtw0GPmkBUlA6N06xdOAlF0w=;
b=HPOJE4CEhJOJlQdbQKLWagrFHF73R3DPrtb7greHGSAZuIYbmjrAXAuxst/4yOSLVt
1rLA1VbIZMR3sCnKRO5Mr8kFF8+AQhmMPopoIBA+sejDn+PXSQHCNNO4pKv3Ok62kPIS
NlnCJjqOQdAhPqs+Gb8/MBaOsrkr5PkaXGYe2OSEZRKEgBHVkEzjhOd+YOLKNy+0ZMTr
qZZK1LXUK7k9dOMXn0fDDf4+MA8OR8sqxqT4QN2yc7OC6Jd2aO4Z77Cnk+amMzDc4Yht
mP2mUPCjxycmdjkl7itzcoUPYHlMXeXnrBUaSR5LWdI+rlSJ/FNYHvLMAXuldDGXH0j6
3+Hw==
X-Gm-Message-State: AD7BkJL9RhmVWNltCTH4A0nUngMTA+QzNjH8IYjBPqQnzmaTr6t4P6/SbHm6oDyQc0pFoA==
X-Received: by 10.140.89.103 with SMTP id u94mr38596711qgd.3.1458055988854;
Tue, 15 Mar 2016 08:33:08 -0700 (PDT)
Received: from randy.nyu.edu (NYUFWA-WLESSAUTHCLIENTS-08.NATPOOL.NYU.EDU.
[216.165.95.79])
by smtp.gmail.com with ESMTPSA id j68sm12863793qge.41.2016.03.15.08.33.08
(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Tue, 15 Mar 2016 08:33:08 -0700 (PDT)
From: Remi Rampin <remirampin@gmail.com>
To: obnam-dev@obnam.org
Date: Tue, 15 Mar 2016 11:31:42 -0400
Message-Id: <1458055902-97595-3-git-send-email-remirampin@gmail.com>
X-Mailer: git-send-email 2.7.3
In-Reply-To: <1458055902-97595-1-git-send-email-remirampin@gmail.com>
References: <56E8255A.9020906@gmail.com>
<1458055902-97595-1-git-send-email-remirampin@gmail.com>
X-Spam-Score: -0.5
X-Spam-Score-int: -4
X-Spam-Bar: /
X-Scanned-By: pepperfish.net, Tue, 15 Mar 2016 15:33:21 +0000
X-Spam-Report: Content analysis details: (-0.5 points)
pts rule name description
---- ---------------------- --------------------------------------------------
1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail'
1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
(remirampin[at]gmail.com)
-0.0 SPF_PASS SPF: sender matches SPF record
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily valid
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low
trust [209.85.192.49 listed in list.dnswl.org]
X-ACL-Warn: message may be spam
X-Scan-Signature: 790749604c9e274f8476ddd9df4e30d2
Cc: Remi Rampin <remirampin@gmail.com>
Subject: [PATCH 2/2] Remove cliapp, use subprocess directly
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
---
setup.py | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/setup.py b/setup.py
index 50ad1ad..f1a726d 100755
--- a/setup.py
+++ b/setup.py
@@ -27,8 +27,6 @@ import subprocess
import sys
import tempfile
-import cliapp
-
import obnamlib
@@ -72,7 +70,7 @@ class Build(build):
def generate_troff(self, program, lang):
with open('%s.1%s' % (program, lang), 'w') as f:
- cliapp.runcmd(
+ subprocess.check_call(
['python', program,
'--generate-manpage=%s.1%s.in' % (program, lang),
'--output=%s.1' % program],
@@ -102,7 +100,7 @@ class BuildDocs(Command):
env = dict(os.environ)
env['MANWIDTH'] = '80'
with open('%s.1.txt' % program, 'w') as f:
- cliapp.runcmd(
+ subprocess.check_call(
['man', '-l', '%s.1' % program],
['col', '-b'],
stdout=f,
@@ -213,8 +211,8 @@ class Check(Command):
if 'REPOSITORY_FORMAT' in os.environ:
return [os.environ['REPOSITORY_FORMAT']]
else:
- return cliapp.runcmd(['./obnam', '--no-default-configs',
- 'list-formats']).splitlines()
+ return subprocess.check_output(['./obnam', '--no-default-configs',
+ 'list-formats']).splitlines()
def run_yarn_for_repo_format(self, repo_format):
print 'run yarn for repository format %s' % repo_format
@@ -258,7 +256,7 @@ class Check(Command):
print "no .git, no nitpick for you"
def check_with_pep8(self):
- output = cliapp.runcmd(['pep8', '--version'])
+ output = subprocess.check_output(['pep8', '--version'])
parts = output.strip().split('.')
# pep8 version 1.5.7 is in Debian jessie. Previous versions
# give bad warnings about whitespace around some operators,
@@ -266,36 +264,38 @@ class Check(Command):
# enough.
if parts >= ['1', '5', '7']:
print 'running pep8'
- cliapp.runcmd(['pep8', 'obnamlib'], stdout=None, stderr=None)
+ subprocess.check_call(['pep8', 'obnamlib'],
+ stdout=None, stderr=None)
else:
print 'not running pep8'
def check_with_pylint(self):
- output = cliapp.runcmd(['pylint', '--version'])
+ output = subprocess.check_output(['pylint', '--version'])
parts = output.splitlines()[0].split('.')
# pylint version 1.3.1 is in Debian jessie. Previous versions
# do not know all the things in the pylint.conf file we use,
# so we only run pylint if it's new enough.
if parts >= ['pylint 1', '3', '1,']:
print 'running pylint'
- cliapp.runcmd(
+ subprocess.check_call(
['pylint', '--rcfile=pylint.conf', 'obnamlib'],
stdout=None, stderr=None)
else:
print 'not running pylint', parts
def check_sources_for_nitpicks(self, sources):
- cliapp.runcmd(['./nitpicker'] + sources, stdout=None, stderr=None)
+ subprocess.check_call(['./nitpicker'] + sources,
+ stdout=None, stderr=None)
def check_copyright_statements(self, sources):
if self.copylint_is_available():
print 'check copyright statements in source files'
- cliapp.runcmd(['copyright-statement-lint'] + sources)
+ subprocess.check_call(['copyright-statement-lint'] + sources)
else:
print 'no copyright-statement-lint: no copyright checks'
def copylint_is_available(self):
- returncode, stdout, stderr = cliapp.runcmd_unchecked(
+ returncode, stdout, stderr = subprocess.call(
['sh', '-c', 'command -v copyright-statement-lint'])
return returncode == 0
@@ -321,7 +321,7 @@ class Check(Command):
pats = [re.compile(x) for x in exclude]
- output = cliapp.runcmd(['git', 'ls-files'])
+ output = subprocess.check_output(['git', 'ls-files'])
result = []
for line in output.splitlines():
for pat in pats:
--
2.7.3
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
|
