1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 17AB224392
for <distix@pieni.net>; Mon, 11 Jul 2016 19:41:34 +0200 (CEST)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id BA68CB8C;
Mon, 11 Jul 2016 18:41:33 +0100 (BST)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1bMfD3-00063J-Kc; Mon, 11 Jul 2016 18:41:33 +0100
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1bMfD2-00063D-8R
for <obnam-dev@obnam.org>; Mon, 11 Jul 2016 18:41:32 +0100
Received: from pieni.net ([95.142.166.37] ident=postfix)
by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80) (envelope-from <liw@liw.fi>) id 1bMfD0-0002pa-Ae
for obnam-dev@obnam.org; Mon, 11 Jul 2016 18:41:32 +0100
Received: from exolobe3.liw.fi (91-145-75-165.bb.dnainternet.fi
[91.145.75.165])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPSA id 85E1724392;
Mon, 11 Jul 2016 19:41:24 +0200 (CEST)
Received: from exolobe3 (localhost [127.0.0.1])
by exolobe3.liw.fi (Postfix) with ESMTPS id D4E1D121D13;
Mon, 11 Jul 2016 20:41:23 +0300 (EEST)
Date: Mon, 11 Jul 2016 20:41:22 +0300
From: Lars Wirzenius <liw@liw.fi>
To: Remi Rampin <remirampin@gmail.com>
Message-ID: <20160711174122.GA14034@exolobe3>
References: <56E8255A.9020906@gmail.com>
<1458055902-97595-1-git-send-email-remirampin@gmail.com>
<1458055902-97595-3-git-send-email-remirampin@gmail.com>
MIME-Version: 1.0
In-Reply-To: <1458055902-97595-3-git-send-email-remirampin@gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-Spam-Score: -2.9
X-Spam-Score-int: -28
X-Spam-Bar: --
X-Scanned-By: pepperfish.net, Mon, 11 Jul 2016 18:41:32 +0100
X-Spam-Report: Content analysis details: (-2.9 points)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam
tool) -0.5 PPF_USER_AGENT User-Agent: exists
0.5 PPF_MESSAGEID_NODOTS Message-Id contains no dots after the @
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-ACL-Warn: message may be spam
X-Scan-Signature: de97edb17eef4c57d29e13fd2fad1a5b
Cc: obnam-dev@obnam.org
Subject: Re: [PATCH 2/2] Remove cliapp, use subprocess directly
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============5820436751021777020=="
Mime-version: 1.0
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
--===============5820436751021777020==
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V"
Content-Disposition: inline
--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Why drop cliapp from the setup.py file? What problem does this solve?
cliapp needs to be installed anyway, since obnamlib imports it.
On Tue, Mar 15, 2016 at 11:31:42AM -0400, Remi Rampin wrote:
> ---
> setup.py | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>=20
> diff --git a/setup.py b/setup.py
> index 50ad1ad..f1a726d 100755
> --- a/setup.py
> +++ b/setup.py
> @@ -27,8 +27,6 @@ import subprocess
> import sys
> import tempfile
> =20
> -import cliapp
> -
> import obnamlib
> =20
> =20
> @@ -72,7 +70,7 @@ class Build(build):
> =20
> def generate_troff(self, program, lang):
> with open('%s.1%s' % (program, lang), 'w') as f:
> - cliapp.runcmd(
> + subprocess.check_call(
> ['python', program,
> '--generate-manpage=3D%s.1%s.in' % (program, lang),
> '--output=3D%s.1' % program],
> @@ -102,7 +100,7 @@ class BuildDocs(Command):
> env =3D dict(os.environ)
> env['MANWIDTH'] =3D '80'
> with open('%s.1.txt' % program, 'w') as f:
> - cliapp.runcmd(
> + subprocess.check_call(
> ['man', '-l', '%s.1' % program],
> ['col', '-b'],
> stdout=3Df,
> @@ -213,8 +211,8 @@ class Check(Command):
> if 'REPOSITORY_FORMAT' in os.environ:
> return [os.environ['REPOSITORY_FORMAT']]
> else:
> - return cliapp.runcmd(['./obnam', '--no-default-configs',
> - 'list-formats']).splitlines()
> + return subprocess.check_output(['./obnam', '--no-default-con=
figs',
> + 'list-formats']).splitlines()
> =20
> def run_yarn_for_repo_format(self, repo_format):
> print 'run yarn for repository format %s' % repo_format
> @@ -258,7 +256,7 @@ class Check(Command):
> print "no .git, no nitpick for you"
> =20
> def check_with_pep8(self):
> - output =3D cliapp.runcmd(['pep8', '--version'])
> + output =3D subprocess.check_output(['pep8', '--version'])
> parts =3D output.strip().split('.')
> # pep8 version 1.5.7 is in Debian jessie. Previous versions
> # give bad warnings about whitespace around some operators,
> @@ -266,36 +264,38 @@ class Check(Command):
> # enough.
> if parts >=3D ['1', '5', '7']:
> print 'running pep8'
> - cliapp.runcmd(['pep8', 'obnamlib'], stdout=3DNone, stderr=3D=
None)
> + subprocess.check_call(['pep8', 'obnamlib'],
> + stdout=3DNone, stderr=3DNone)
> else:
> print 'not running pep8'
> =20
> def check_with_pylint(self):
> - output =3D cliapp.runcmd(['pylint', '--version'])
> + output =3D subprocess.check_output(['pylint', '--version'])
> parts =3D output.splitlines()[0].split('.')
> # pylint version 1.3.1 is in Debian jessie. Previous versions
> # do not know all the things in the pylint.conf file we use,
> # so we only run pylint if it's new enough.
> if parts >=3D ['pylint 1', '3', '1,']:
> print 'running pylint'
> - cliapp.runcmd(
> + subprocess.check_call(
> ['pylint', '--rcfile=3Dpylint.conf', 'obnamlib'],
> stdout=3DNone, stderr=3DNone)
> else:
> print 'not running pylint', parts
> =20
> def check_sources_for_nitpicks(self, sources):
> - cliapp.runcmd(['./nitpicker'] + sources, stdout=3DNone, stderr=
=3DNone)
> + subprocess.check_call(['./nitpicker'] + sources,
> + stdout=3DNone, stderr=3DNone)
> =20
> def check_copyright_statements(self, sources):
> if self.copylint_is_available():
> print 'check copyright statements in source files'
> - cliapp.runcmd(['copyright-statement-lint'] + sources)
> + subprocess.check_call(['copyright-statement-lint'] + sources)
> else:
> print 'no copyright-statement-lint: no copyright checks'
> =20
> def copylint_is_available(self):
> - returncode, stdout, stderr =3D cliapp.runcmd_unchecked(
> + returncode, stdout, stderr =3D subprocess.call(
> ['sh', '-c', 'command -v copyright-statement-lint'])
> return returncode =3D=3D 0
> =20
> @@ -321,7 +321,7 @@ class Check(Command):
> =20
> pats =3D [re.compile(x) for x in exclude]
> =20
> - output =3D cliapp.runcmd(['git', 'ls-files'])
> + output =3D subprocess.check_output(['git', 'ls-files'])
> result =3D []
> for line in output.splitlines():
> for pat in pats:
> --=20
> 2.7.3
>=20
>=20
> _______________________________________________
> obnam-dev mailing list
> obnam-dev@obnam.org
> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam=
=2Eorg
>=20
--=20
Schr=F6dinger's backup hypothesis: the condition of any backup is
undefined until a restore is attempted. -- andrewsh
--xHFwDpU9dbj6ez1V
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJXg9pCAAoJEGwvphbseiAx9joQAKLZpONejWq64c/sU6L2kec6
md4aUnKy6xCMUHelPsa1scloxUvHETqwrMplurdK7fPVp2kXECKSZKL8Fk6BECX8
xG2f8fTOMmZkNH3KeFfUTcCG/qAcLukazKCkX4XfF5rKW+Opmgxr3A+vKmbdABPR
JndwJPtJmuQY11bP3FEJq5/GHsmZESjqEMVAU86Kqp+4UVe3xXu6o1+0Bs+TtCfN
oaKYom8U4jh8Hm/pMZ4dtUxGRu0wcqrS0vJg/hhQf1wZS+AlZufkMnj43ozWOTgb
HyJ768RDxz3o+KKp5sS+t9bFeMYQGyX3VoqDVLP3/ZJ8V4JYt85fDO5hhzfcju78
FtSVhoMDQsgjBO/zsPyAEAKAcf0dv4NrclIJ2gMUPf3e3D1gyXZAMcNwlbvVKiu5
917g9G0tlpuKefE3IXc5qNIEBx2E7ku6mn4Dg+sPidLH7dslpuEhZFMUx4Ouza7O
Ich7zLH1F+aC5Wq11HSCBjQSk+8su8UQ/xaKQx5dlcHgRkHGOnjzPwoYQ5KRK81e
t9QhQaxm6LdgbgNhGn6FJakYvXjD9A5XcEW7hm1xDtYI8DhTwvxSU4MeVusUXt4T
VkXbZSKS6ratwiqpXn+cjedOzsGSe++wiDZlrnN2p77Ct8urNs19jsvySTYLoSVG
OdLP3wPLPj83hcqtwbGP
=i913
-----END PGP SIGNATURE-----
--xHFwDpU9dbj6ez1V--
--===============5820436751021777020==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
--===============5820436751021777020==--
|
