1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id 6FA7C2D9F1
for <distix@pieni.net>; Sun, 11 Oct 2015 11:04:12 +0200 (CEST)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id F20BE320;
Sun, 11 Oct 2015 10:04:11 +0100 (BST)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1ZlCY7-0002ct-Qr; Sun, 11 Oct 2015 10:04:11 +0100
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1ZlCY6-0002cl-28
for <obnam-dev@obnam.org>; Sun, 11 Oct 2015 10:04:10 +0100
Received: from pieni.net ([95.142.166.37] ident=postfix)
by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80) (envelope-from <liw@liw.fi>) id 1ZlCY3-0006an-Q5
for obnam-dev@obnam.org; Sun, 11 Oct 2015 10:04:09 +0100
Received: from exolobe1.liw.fi (82-181-8-107.bb.dnainternet.fi [82.181.8.107])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPSA id 3AB072D9F1;
Sun, 11 Oct 2015 11:04:01 +0200 (CEST)
Received: from exolobe1.liw.fi (localhost [127.0.0.1])
by exolobe1.liw.fi (Postfix) with ESMTPS id 899B14084E;
Sun, 11 Oct 2015 12:04:00 +0300 (EEST)
Date: Sun, 11 Oct 2015 12:03:59 +0300
From: Lars Wirzenius <liw@liw.fi>
To: Ben Boeckel <mathstuf@gmail.com>
Message-ID: <20151011090359.GA11145@exolobe1.liw.fi>
References: <1441948936-12526-1-git-send-email-mathstuf@gmail.com>
<1443159474-27126-1-git-send-email-mathstuf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1443159474-27126-1-git-send-email-mathstuf@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -3.4
X-Spam-Score-int: -33
X-Spam-Bar: ---
X-Scanned-By: pepperfish.net, Sun, 11 Oct 2015 10:04:09 +0100
X-Spam-Report: Content analysis details: (-3.4 points)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam
tool) -0.5 PPF_USER_AGENT User-Agent: exists
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-ACL-Warn: message may be spam
X-Scan-Signature: 95307e19e51ef85356cdc588a20b2845
Cc: obnam-dev@obnam.org
Subject: Re: [PATCH v4 0/4] GPGHOMEDIR improvements
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
Thank you, I've reviewed the code, ran the test suite, fixed the
nitpick problem (the version of pep8 on my computer wants at least two
spaces before an inline comment), merged to master, and pushed to
git.liw.fi.
On Fri, Sep 25, 2015 at 01:37:50AM -0400, Ben Boeckel wrote:
> These seem related enough to warrant bundling it all together. I've place the
> refactoring and fix commits at the base to make cherry-picking a subset easier.
>
> First, I refactored _gpg_pipe to use _gpg since all it does is set up
> --passphrase-fd and the base flags are the same.
>
> Second, I added support for gpghome to the symmetric functions and fixed the
> tests because if my USB key is not plugged in, the symlinks in the default gpg
> keyring are broken and gpg needs to read *something*, but this fails.
>
> The third patch fixes the test suite for symmetric keys to use a
> guaranteed-to-not-be-broken keyring by creating a temporary directory for it.
>
> The last commit implements the gnupghome configuration with tests, now also
> passing it to the symmetric key functions.
>
> Thanks,
>
> Ben Boeckel (4):
> encryption: refactor _gpg_pipe to use _gpg
> encryption: support custom gpghome in symmetric key functions
> encryption_tests: make robust against bad default keyrings
> encryption_plugin: add a gnupghome configuration option
>
> obnam.1.in | 5 +++++
> obnamlib/encryption.py | 28 +++++++++++-----------------
> obnamlib/encryption_tests.py | 15 ++++++++++++---
> obnamlib/plugins/encryption_plugin.py | 27 +++++++++++++++++++++------
> yarns/0060-encryption.yarn | 16 ++++++++++++++++
> yarns/9000-implements.yarn | 26 ++++++++++++++++++++++++++
> 6 files changed, 91 insertions(+), 26 deletions(-)
>
> --
> 2.5.3
>
>
> _______________________________________________
> obnam-dev mailing list
> obnam-dev@obnam.org
> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
>
--
Schrödinger's backup hypothesis: the condition of any backup is
undefined until a restore is attempted. -- andrewsh
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
|
