summaryrefslogtreecommitdiff
path: root/tickets/b6df8a5d7d3d4b7e8c2ddf8c95cfc33d/Maildir/new/1455998996.M410783P17339Q49.exolobe1
blob: 35ca8b0870d4eb77de543d7d678646ae28d1d96e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pieni.net (Postfix) with ESMTPS id B2A082E361
	for <distix@pieni.net>; Sun, 13 Sep 2015 16:05:44 +0200 (CEST)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
	by bagpuss.pepperfish.net (Postfix) with ESMTP id 31BFADE;
	Sun, 13 Sep 2015 15:05:44 +0100 (BST)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
	by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
	id 1Zb7ua-0006Gk-18; Sun, 13 Sep 2015 15:05:44 +0100
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
 by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
 id 1Zb7uY-0006Ge-9C
 for <obnam-dev@obnam.org>; Sun, 13 Sep 2015 15:05:42 +0100
Received: from mail-ig0-f175.google.com ([209.85.213.175])
 by mx0.pepperfish.net with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128)
 (Exim 4.80) (envelope-from <mathstuf@gmail.com>) id 1Zb7uV-0002fJ-Rp
 for obnam-dev@obnam.org; Sun, 13 Sep 2015 15:05:42 +0100
Received: by igcpb10 with SMTP id pb10so73943049igc.1
 for <obnam-dev@obnam.org>; Sun, 13 Sep 2015 07:05:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=date:from:to:cc:subject:message-id:reply-to:references:mime-version
 :content-type:content-disposition:content-transfer-encoding
 :in-reply-to:user-agent;
 bh=gHOs5ag4nqjqKtPFaAv4ywC21jbza6csv9pPTEtY4DA=;
 b=xGL6czuToepOY3NdiOzv8AmQiwMuLWt0IYbITOC6LmgsXknGfujrI4JoMnETH5qeCg
 gtTLOJ0jRD/DoHqvFtt1LNqnx4EmVZtCC3V3R3jD1DwCT2EG5Ly9MjdS+yKgTQUENBDw
 OGRgJBtstumylGtVkM/SXh72uUFfuIVQErVPhiBmUH68ks1PqnjPeZdkLP/EJz5yEBIT
 r1mmQjVf7GnhKpouo+Hub/KcjPoj7jX7HwwGOzvE+yGl0jpaNG/6RJXIbU5HE1ryVxEW
 /++O1K7JglTIdWlbI4gHgY+m71riba9bE0y6VpD7v56sWiT0VW9tmd4zNErHJ2Dzfdft
 U2aQ==
X-Received: by 10.50.124.4 with SMTP id me4mr11286982igb.34.1442153127101;
 Sun, 13 Sep 2015 07:05:27 -0700 (PDT)
Received: from localhost (157.sub-70-209-142.myvzw.com. [70.209.142.157])
 by smtp.gmail.com with ESMTPSA id 92sm4238256ioq.3.2015.09.13.07.05.25
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 13 Sep 2015 07:05:26 -0700 (PDT)
Date: Sun, 13 Sep 2015 10:05:23 -0400
From: Ben Boeckel <mathstuf@gmail.com>
To: Lars Wirzenius <liw@liw.fi>
Message-ID: <20150913140523.GA21436@bronto-burt.dev.benboeckel.net>
References: <1441948936-12526-1-git-send-email-mathstuf@gmail.com>
 <1441948936-12526-2-git-send-email-mathstuf@gmail.com>
 <20150912190247.GA11279@exolobe1.liw.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150912190247.GA11279@exolobe1.liw.fi>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Score: -2.0
X-Spam-Score-int: -19
X-Spam-Bar: --
X-Scanned-By: pepperfish.net, Sun, 13 Sep 2015 15:05:42 +0100
X-Spam-Report: Content analysis details: (-2.0 points)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 PPF_USER_AGENT_MUTT    User-Agent: contains Mutt (Mutt isn't a spam
 tool) -0.5 PPF_USER_AGENT         User-Agent: exists
 1.0 PPF_FROM_CONTAINS_MAIL The From header contains 'mail'
 1.2 FREEMAIL_FROM Sender email is commonly abused enduser mail provider
 (mathstuf[at]gmail.com)
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
 trust [209.85.213.175 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
 -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's
 domain
 0.1 DKIM_SIGNED            Message has a DKIM or DK signature,
 not necessarily valid
 -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
X-ACL-Warn: message may be spam
X-Scan-Signature: e606bea56426b7460dd1a96e279d41e5
Cc: obnam-dev@obnam.org
Subject: Re: [PATCH 1/3] encryption_plugin: add a gpg-homedir configuration
 option
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mathstuf@gmail.com
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
 <mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
 <mailto:obnam-dev-request@obnam.org?subject=subscribe>
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org

On Sat, Sep 12, 2015 at 22:02:47 +0300, Lars Wirzenius wrote:
> I've applied the other two patches, thank you. I am not sure about
> this patch, to add --gpg-homedir. Is it not enough to just set
> GNUPGHOME in the environment? I guess it might be easier to set it in
> a config file and not have to set the environment variable on each
> obnam invocation.

That's exactly the case I had :) . The unit file set it…but I had to
manually do so for things like `obnam generations`.

> If the setting is added, I'd rather it was called --gnupghome, to
> mirror the environment variable. It'd also be nice to have a test that
> it works correctly. Could you update the patch to rename the setting?

Yeah, that makes sense.

I started to look at how to add a test. The mechanisms are already
"tested" (in that they are used, but they are not the thing being
directly tested) used are already in place (gpghome=...) in
encryption_tests.py. How are plugins tested?

--Ben

_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org