1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPS id D8A2624BB0
for <distix@pieni.net>; Thu, 14 Jul 2016 19:02:19 +0200 (CEST)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
by bagpuss.pepperfish.net (Postfix) with ESMTP id 5A8E43EA;
Thu, 14 Jul 2016 18:02:19 +0100 (BST)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1bNk1j-0004kc-6v; Thu, 14 Jul 2016 18:02:19 +0100
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
id 1bNk1h-0004kV-QL
for <obnam-dev@obnam.org>; Thu, 14 Jul 2016 18:02:17 +0100
Received: from pieni.net ([95.142.166.37] ident=postfix)
by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
(Exim 4.80) (envelope-from <liw@liw.fi>) id 1bNk1f-0001jA-Dr
for obnam-dev@obnam.org; Thu, 14 Jul 2016 18:02:17 +0100
Received: from exolobe3.liw.fi (91-145-75-165.bb.dnainternet.fi
[91.145.75.165])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by pieni.net (Postfix) with ESMTPSA id 548BB24BB0;
Thu, 14 Jul 2016 19:02:08 +0200 (CEST)
Received: from exolobe3 (localhost [127.0.0.1])
by exolobe3.liw.fi (Postfix) with ESMTPS id 86CA2120B38;
Thu, 14 Jul 2016 20:02:07 +0300 (EEST)
Date: Thu, 14 Jul 2016 20:02:06 +0300
From: Lars Wirzenius <liw@liw.fi>
To: Michel Alexandre Salim <michel@michel-slm.name>
Message-ID: <20160714170206.GE4968@exolobe3>
References: <CAMpBwxzbLH+KQCDAMp-JeoHx8XrzaoBq9MAeYfNAb+eh2roM-w@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMpBwxzbLH+KQCDAMp-JeoHx8XrzaoBq9MAeYfNAb+eh2roM-w@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-Spam-Score: -2.9
X-Spam-Score-int: -28
X-Spam-Bar: --
X-Scanned-By: pepperfish.net, Thu, 14 Jul 2016 18:02:17 +0100
X-Spam-Report: Content analysis details: (-2.9 points)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam
tool) -0.5 PPF_USER_AGENT User-Agent: exists
0.5 PPF_MESSAGEID_NODOTS Message-Id contains no dots after the @
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-ACL-Warn: message may be spam
X-Scan-Signature: 6378d0c0a451b9c9f4ef76680c5545e5
Cc: "obnam-dev@obnam.org" <obnam-dev@obnam.org>
Subject: Re: [PATCH] fix fuse_plugin typo referencing non-existent method
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
<mailto:obnam-dev-request@obnam.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============3763108587698118660=="
Mime-version: 1.0
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org
--===============3763108587698118660==
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="u5E4XgoOPWr4PD9E"
Content-Disposition: inline
--u5E4XgoOPWr4PD9E
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Thanks, applied.
On Sat, Jun 04, 2016 at 02:54:59PM +0000, Michel Alexandre Salim wrote:
> Hi Lars,
>=20
> Please find below a patch that fixes a typo in fuse_plugin (discovered in
> the build of 1.17 we currently ship, but still present in master too).
>=20
> The repo interface exposes the `get_client_generation_ids` method, but in=
one
> location in `fuse_plugin` it is called as `get_clientgeneration_ids`.
>=20
> Best regards,
>=20
> --=20
> Michel Alexandre Salim
> Fedora Project Obnam maintainer
> From 344799dd5963b5c4fcf1089f16ccc799bb054cfb Mon Sep 17 00:00:00 2001
> From: Michel Alexandre Salim <salimma@fedoraproject.org>
> Date: Sat, 4 Jun 2016 21:48:01 +0700
> Subject: [PATCH] Fix typo in fuse_plugin, calling the wrong repo method
>=20
> The repo interface exposes the `get_client_generation_ids` method, but in
> one location in `fuse_plugin` it is called as `get_clientgeneration_ids`.
>=20
> As reported in Fedora bugzilla,
> https://bugzilla.redhat.com/show_bug.cgi?id=3D1340138
>=20
> #1340138 [abrt] obnam: fuse_plugin.py:391:statfs:AttributeError: 'Rep=
ositoryFormat6' object has no attribute 'get_clientgeneration_ids'
> ---
> obnamlib/plugins/fuse_plugin.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/obnamlib/plugins/fuse_plugin.py b/obnamlib/plugins/fuse_plug=
in.py
> index f0129ca..97025df 100644
> --- a/obnamlib/plugins/fuse_plugin.py
> +++ b/obnamlib/plugins/fuse_plugin.py
> @@ -388,7 +388,7 @@ class ObnamFuse(fuse.Fuse):
> total_data =3D sum(
> self.obnam.repo.get_generation_key(
> gen, obnamlib.REPO_GENERATION_TOTAL_DATA)
> - for gen in self.obnam.repo.get_clientgeneration_ids(client_n=
ame))
> + for gen in self.obnam.repo.get_client_generation_ids(client_=
name))
> =20
> files =3D sum(
> self.obnam.repo.get_generation_key(
> --=20
> 2.7.4
>=20
> _______________________________________________
> obnam-dev mailing list
> obnam-dev@obnam.org
> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam=
=2Eorg
--=20
Schr=F6dinger's backup hypothesis: the condition of any backup is
undefined until a restore is attempted. -- andrewsh
--u5E4XgoOPWr4PD9E
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJXh8WOAAoJEGwvphbseiAxnrIP/RBBRQPiRnNRLXdYzBYFvSHf
gPuI3JnkTjw8s7eXK55o2BEjQZqjNLHRqZypQ4KMwdJrvWcompW0S2cDjSPBAu8L
2jp1wK7J19NrTcAZp7fYdqw+wtXgWfgwiKTFbf421A/JIgO4haCXGFkXk/07Rwb4
anErhJAGjXEYzqo/QcGvwWZjVOs7+tzhy9HR9FlEIrNBrFoJbjbDudqE7DO0eXwV
7GKxaiQhhLYb1TyhnQIGUFhb9JbaBmxhRrN31N8p+dp12t16OYhHadIgZ0lJ3h+h
czmKbsFqHO6aQcf9ETuLzz0Onia/YfSzcbXfDdNK0lm/i3setL6volhh0JbooT+7
5YmKgkSmCYrg+gSpSVaoxI3gqZJ9RvoLhFQpeyUNs0WQBZikbCxBVgJfbzpA79If
mkyfNE0flOQtywLyFzgn2uyD7R3lgSDJB801zetD7wkIW25kTK/2tx4qDocpjnko
k+AZ3bBuQFrWtJG43YoJ90w1VQbaoMOfttzxs8CB3AH9Jil4qu9pmb9n8lbk10Ty
nqqwSPLcJgcjIbXK+IUOYzKPRPFSqNf+/3AvkIeyIC9FzgbY2zADkBYetkYCBDfr
cBzfWiK5awNgycqwd6NJIQbZsNo2E940CoFmeLna26AprES6+fyO50N9lkg1UkGr
VP+Vw1WxeVj5UduMTPun
=fXDC
-----END PGP SIGNATURE-----
--u5E4XgoOPWr4PD9E--
--===============3763108587698118660==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org
--===============3763108587698118660==--
|
