Nitpick only about long lines with whitespace

Whitespace-less lines can't be broken into shorter lines,
so there's no point in complaining about them. As an example,
a line might contain a long URL, and that shouldn't be broken.

1 files changed, 9 insertions, 1 deletions

diff --git a/nitpicker b/nitpicker
index ef0a22f4..dd164f46 100755
--- a/nitpicker
+++ b/nitpicker
@@ -36,6 +36,8 @@ class LongLine(obnamlib.ObnamError):
 
 class SourceCodeNitpicker(cliapp.Application):
 
+    max_line_length = 79
+
     def setup(self):
         self.errors = False
 
@@ -56,11 +58,17 @@ class SourceCodeNitpicker(cliapp.Application):
 
     def check_for_long_line(self, filename, line):
         expanded = line.expandtabs()
-        if len(expanded) > 79:
+        if self.line_is_long(expanded) and self.line_can_be_broken(line):
             self.error(
                 filename, self.lineno,
                 LongLine(line=line, length=len(expanded)))
 
+    def line_is_long(self, line):
+        return len(line) > self.max_line_length
+
+    def line_can_be_broken(self, line):
+        return len(line.split()) > 1
+
     def error(self, filename, lineno, error):
         self.output.write(
             '%s:%s: %s\n' % (filename, lineno, str(error)))