fix: improve logging in runcmd_run

kwargs are logged as a dict. This helps me debug why reference.md fails.

1 files changed, 8 insertions, 4 deletions

diff --git a/share/python/lib/runcmd.py b/share/python/lib/runcmd.py
index c4d297c..1eddb9e 100644
--- a/share/python/lib/runcmd.py
+++ b/share/python/lib/runcmd.py
@@ -65,20 +65,24 @@ def runcmd_run(ctx, argv, **kwargs):
     if pp:
         env["PATH"] = pp + ":" + env["PATH"]
 
+    kwargs["stdout"] = subprocess.PIPE
+    kwargs["stderr"] = subprocess.PIPE
+
     logging.debug(f"runcmd_run")
     log_dict(dict(enumerate(argv)), "argv", level=1)
     log_dict(env, "env:", level=1)
-    p = subprocess.Popen(
-        argv, stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env, **kwargs
-    )
+    log_dict(kwargs, "kwargs:", level=1)
+
+    p = subprocess.Popen(argv, env=env, **kwargs)
     stdout, stderr = p.communicate("")
+
     ns["argv"] = argv
     ns["stdout.raw"] = stdout
     ns["stderr.raw"] = stderr
     ns["stdout"] = stdout.decode("utf-8")
     ns["stderr"] = stderr.decode("utf-8")
     ns["exit"] = p.returncode
-    log_dict(ctx.as_dict(), "ctx", level=1)
+
     log_dict(ns.as_dict(), "ns", level=1)