diff options
| author | Lars Wirzenius <lwirzenius@wikimedia.org> | 2019-05-02 19:13:06 +0300 |
|---|---|---|
| committer | Lars Wirzenius <lwirzenius@wikimedia.org> | 2019-05-02 19:13:06 +0300 |
| commit | 305ef306f85da73aa880e0597854fafe54eb1c5b (patch) | |
| tree | 3658b522efcc9adc6851c4a3e1538ba1148b122c | |
| parent | 4d837d04c19b4f2688df4bd1e525c60c9291bd7f (diff) | |
| download | wmf-ci-arch-305ef306f85da73aa880e0597854fafe54eb1c5b.tar.gz | |
Change: clarify GERRIT
| -rw-r--r-- | ci-arch.mdwn | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ci-arch.mdwn b/ci-arch.mdwn index 80cbb21..9a7421a 100644 --- a/ci-arch.mdwn +++ b/ci-arch.mdwn @@ -110,7 +110,9 @@ TITLE: Future WMF CI architecture * **(GERRIT)** Must work with Gerrit as well as other self-hostable code-review systems (e.g., GitLab), if we decide to move to that - later. + later. This means, code review happens on Gerrit, after building and + automated tests pass, and positive code review triggers deployment + to production. * **(SHORTCYCLETIME)** Must enable us to have a short cycle time (from idea to running in production). CI is not the only thing that |