diff options
| author | Lars Wirzenius <lwirzenius@wikimedia.org> | 2019-05-13 17:08:45 +0300 |
|---|---|---|
| committer | Lars Wirzenius <lwirzenius@wikimedia.org> | 2019-05-13 17:08:45 +0300 |
| commit | 08d33c97433ca4f758ecdd045db8bb1dac925387 (patch) | |
| tree | 05b54aca334a12ae46501d342b23c842bc25d387 /ci-arch.mdwn | |
| parent | dc92510b69eafde75dcdc8bb14b9f1ef28591992 (diff) | |
| download | wmf-ci-arch-08d33c97433ca4f758ecdd045db8bb1dac925387.tar.gz | |
Add: note that wip changes can be reviewed before CI
Diffstat (limited to 'ci-arch.mdwn')
| -rw-r--r-- | ci-arch.mdwn | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/ci-arch.mdwn b/ci-arch.mdwn index cd052f2..3b365c5 100644 --- a/ci-arch.mdwn +++ b/ci-arch.mdwn @@ -424,11 +424,13 @@ happens when a developer is finished with a change: production environment The commit and acceptance stages are triggered as soon as developer -pushes changes to be reviewed. Human reviews won't be requested until -the two stages pass, as there's no point in spending human attention -on things that are not going to be candidates for deployment to -production. The two stages may be re-run after code review, to make -sure nothing unforeseen has changed while the review took place. +pushes changes to be reviewed. Human reviews won't be requested +automatically until the two stages pass, as there's no point in +spending human attention on things that are not going to be candidates +for deployment to production. Developer may request reviews of +work-in-progress changes when they want. The two stages may be re-run +after code review, to make sure nothing unforeseen has changed while +the review took place. Other stages may run in parallel with code review, and if they fail they may nullify the release candidacy of the change. For example, |