diff options
author | Distix listener <distix@pieni.net> | 2016-02-20 21:46:30 +0100 |
---|---|---|
committer | Distix listener <distix@pieni.net> | 2016-02-20 21:46:30 +0100 |
commit | d190ffef52edc6307eed4920a1ae1fc90aa27f8e (patch) | |
tree | 5c1f6f376717bb6205df787577bbf73b0a3cf106 /tickets/e21786a47a674589abdcee9b03f811da | |
parent | 8c087e41fdda5d9508b9c95ea57fbd079142633d (diff) | |
download | obnam-dev-distix-d190ffef52edc6307eed4920a1ae1fc90aa27f8e.tar.gz |
imported mails
Diffstat (limited to 'tickets/e21786a47a674589abdcee9b03f811da')
-rw-r--r-- | tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1456001180.M790633P8737Q25.hrun | 218 |
1 files changed, 218 insertions, 0 deletions
diff --git a/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1456001180.M790633P8737Q25.hrun b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1456001180.M790633P8737Q25.hrun new file mode 100644 index 0000000..9a10bfe --- /dev/null +++ b/tickets/e21786a47a674589abdcee9b03f811da/Maildir/new/1456001180.M790633P8737Q25.hrun @@ -0,0 +1,218 @@ +Return-Path: <obnam-dev-bounces@obnam.org> +X-Original-To: distix@pieni.net +Delivered-To: distix@pieni.net +Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPS id 556A42396A + for <distix@pieni.net>; Sun, 20 Dec 2015 15:51:54 +0100 (CET) +Received: from platypus.pepperfish.net (unknown [10.112.100.20]) + by bagpuss.pepperfish.net (Postfix) with ESMTP id C984AB71; + Sun, 20 Dec 2015 14:51:53 +0000 (GMT) +Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1aAfKz-000852-Jy; Sun, 20 Dec 2015 14:51:53 +0000 +Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net) + by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian)) + id 1aAfKy-00084s-02 + for <obnam-dev@obnam.org>; Sun, 20 Dec 2015 14:51:52 +0000 +Received: from pieni.net ([95.142.166.37] ident=postfix) + by mx0.pepperfish.net with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) + (Exim 4.80) (envelope-from <liw@liw.fi>) id 1aAfKu-0002nr-8c + for obnam-dev@obnam.org; Sun, 20 Dec 2015 14:51:51 +0000 +Received: from exolobe1.liw.fi (unknown [82.129.76.156]) + (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by pieni.net (Postfix) with ESMTPSA id 509D22392F; + Sun, 20 Dec 2015 15:51:42 +0100 (CET) +Received: from exolobe1.liw.fi (localhost [127.0.0.1]) + by exolobe1.liw.fi (Postfix) with ESMTPS id C30C441391; + Sun, 20 Dec 2015 15:51:41 +0100 (CET) +Date: Sun, 20 Dec 2015 15:51:40 +0100 +From: Lars Wirzenius <liw@liw.fi> +To: Kyle Manna <2bluesc@gmail.com> +Message-ID: <20151220145140.GG2511@exolobe1.liw.fi> +References: <CAM9fjH50TfjxaY9spb8tFgxGfpXJ2kyw93PpnGrPeNO4AL4wNA@mail.gmail.com> +MIME-Version: 1.0 +In-Reply-To: <CAM9fjH50TfjxaY9spb8tFgxGfpXJ2kyw93PpnGrPeNO4AL4wNA@mail.gmail.com> +User-Agent: Mutt/1.5.23 (2014-03-12) +X-Spam-Score: -3.4 +X-Spam-Score-int: -33 +X-Spam-Bar: --- +X-Scanned-By: pepperfish.net, Sun, 20 Dec 2015 14:51:51 +0000 +X-Spam-Report: Content analysis details: (-3.4 points) + pts rule name description + ---- ---------------------- -------------------------------------------------- + -1.0 PPF_USER_AGENT_MUTT User-Agent: contains Mutt (Mutt isn't a spam + tool) -0.5 PPF_USER_AGENT User-Agent: exists + -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% + [score: 0.0000] +X-ACL-Warn: message may be spam +X-Scan-Signature: 0707f752aedcb6e37cfeb9ca33967819 +Cc: obnam-dev@obnam.org +Subject: Re: Paramiko 1.16 breaks obnam +X-BeenThere: obnam-dev@obnam.org +X-Mailman-Version: 2.1.5 +Precedence: list +List-Id: Obnam development discussions <obnam-dev-obnam.org> +List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=unsubscribe> +List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org> +List-Post: <mailto:obnam-dev@obnam.org> +List-Help: <mailto:obnam-dev-request@obnam.org?subject=help> +List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>, + <mailto:obnam-dev-request@obnam.org?subject=subscribe> +Content-Type: multipart/mixed; boundary="===============4127835399124973813==" +Mime-version: 1.0 +Sender: obnam-dev-bounces@obnam.org +Errors-To: obnam-dev-bounces@obnam.org + + +--===============4127835399124973813== +Content-Type: multipart/signed; micalg=pgp-sha256; + protocol="application/pgp-signature"; boundary="V32M1hWVjliPHW+c" +Content-Disposition: inline + + +--V32M1hWVjliPHW+c +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +Hi, sorry about taking so long to answer. + +This is an unfortunate change in paramiko. Not that the new feature in +prefetch is bad, but the change is backwards incompatible. Your patch +makes Obnam work with paramiko 1.16, but breaks it for 1.15.1. + +I don't want to break Obnam for paramiko 1.15.1, so this is going to +require Obnam checking what version of paramiko it is talking to, and +calling it differently depending. This is an example of why it's good +to be careful about dependencies. + +I rewrote the patch to work with older paramiko and credited you in +the commit message and NEWS file. Thank you! + +On Fri, Nov 06, 2015 at 09:45:49AM -0800, Kyle Manna wrote: +> After upgrading python2-paramiko (1.15.3-1 -> 1.16.0-1), the sftp lib cra= +shes: +>=20 +> Traceback (most recent call last): +> File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 189, in _run +> self.process_args(args) +> File "/usr/lib/python2.7/site-packages/obnamlib/app.py", line 207, +> in process_args +> cliapp.Application.process_args(self, args) +> File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 566, in +> process_args +> method(args[1:]) +> File "/usr/lib/python2.7/site-packages/obnamlib/plugins/force_lock_plug= +in.py", +> line 49, in force_lock +> for client_name in repo.get_client_names(): +> File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_fmt_6.py", +> line 154, in get_client_names +> return self._client_list.list_clients() +> File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/clientlist.py", +> line 78, in list_clients +> if self.init_forest() and self.forest.trees: +> File "/usr/lib/python2.7/site-packages/obnamlib/fmt_6/repo_tree.py", +> line 63, in init_forest +> allow_writes=3Dallow_writes) +> File "/usr/lib/python2.7/site-packages/larch/forest.py", line 199, +> in open_forest +> check_size('key_size', key_size, BadKeySize) +> File "/usr/lib/python2.7/site-packages/larch/forest.py", line 193, +> in check_size +> if keyname not in ns.get_metadata_keys(): +> File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +> line 167, in get_metadata_keys +> self._load_metadata() +> File "/usr/lib/python2.7/site-packages/larch/nodestore_disk.py", +> line 148, in _load_metadata +> data =3D self.journal.cat(self.metadata_name) +> File "/usr/lib/python2.7/site-packages/larch/journal.py", line 162, in = +cat +> return self.fs.cat(filename) +> File "/usr/lib/python2.7/site-packages/obnamlib/repo_fs.py", line 56, i= +n cat +> data =3D self.fs.cat(filename) +> File "/usr/lib/python2.7/site-packages/obnamlib/plugins/sftp_plugin.py", +> line 588, in cat +> f.prefetch() +> TypeError: prefetch() takes exactly 2 arguments (1 given) +>=20 +>=20 +> Documentation confirms the added file size argument: +> http://docs.paramiko.org/en/1.15/api/sftp.html +> http://docs.paramiko.org/en/1.16/api/sftp.html +>=20 +> Change that broke it: +> https://github.com/paramiko/paramiko/commit/49072f3537a8981e9d448c22481a1= +d2b92c03643 +>=20 +> My patch to fix this by prefetching the entire file: +> https://gist.github.com/kylemanna/cc951490b992050f86ac +>=20 +> --- a/obnamlib/plugins/sftp_plugin.py +> +++ b/obnamlib/plugins/sftp_plugin.py +> @@ -555,7 +555,7 @@ class SftpFS(obnamlib.VirtualFileSystem): +> def cat(self, pathname): +> self._delay() +> f =3D self.open(pathname, 'rb') +> - f.prefetch() +> + f.prefetch(self.lstat(pathname).st_size) +> chunks =3D [] +> while True: +> chunk =3D f.read(self.chunk_size) +> =E1=90=A7 +>=20 +> _______________________________________________ +> obnam-dev mailing list +> obnam-dev@obnam.org +> http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam= +=2Eorg +>=20 + +--=20 +Schr=C3=B6dinger's backup hypothesis: the condition of any backup is +undefined until a restore is attempted. -- andrewsh + +--V32M1hWVjliPHW+c +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: Digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iQIcBAEBCAAGBQJWdsB8AAoJEGwvphbseiAxYv8QAIzxiNVxnkI7Pc+WWv3Zx+/t +RLECjobdo2obkJC2CIQY4Xj1NHuNnxJKzmdn2dP9t7lSVewqLrIt/I3iO26HpI+F +BH1fEQAnzRdO33hxjgtsx2B8T/9AracNSexTUxoa2aahW9ZVQ5plfzga8e1eCIsH +2ekLi8nGPPSPDPHQyfQngBBHm9CJae8Sun04YWiDKNzZcK1SSxwJEBAA0Q9fDTXN +JaOgNOxXG9bbs752TMgzxF1jqTbwVNF7vxYIMuhIWgHhohb+A9tprx6y4lFkKUsY +lRu8LfHjyujhv3IlmGZFI5SfSiWUWqyauJnCnmOIOv0/UfvkEKwASI2Xp95Uz5Dd +hPMTMXfLeHW06KoW5e/s3b56laK3ntpsta7+Klt4BPTtCH2p/k3tLdK1a/kHEezF +vw7fvvPDmOyN+bQEKW7z/489ODD+/H4dJJgce7srEDmRjjbWS4eKb1B7TQY7CPO2 +U7MqaRQ0jAZNgdKzQfRtbCvJISZihApAUVo5472laeHIqNm85Q1a6xhnnh3Su3sz +s2Gq27UsdE0vkA7FR5iK1HBT/4AxSf1MTGLGZ3ydkLHdzNk5NxcINa8UJx4eh09v +0Se5F/LsC+tmsPS0pnUxsvGunBwUfrcLX2izrVpMBlyvwLOJ/evd0fV7V9B4LhhP +hj0lIcSCMdl3NWqeopWi +=n2CZ +-----END PGP SIGNATURE----- + +--V32M1hWVjliPHW+c-- + + +--===============4127835399124973813== +Content-Type: text/plain; charset="us-ascii" +MIME-Version: 1.0 +Content-Transfer-Encoding: 7bit +Content-Disposition: inline + +_______________________________________________ +obnam-dev mailing list +obnam-dev@obnam.org +http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org + +--===============4127835399124973813==-- + |