summaryrefslogtreecommitdiff
path: root/tickets/829d5f9060144a30bd44cb946b0ba1c9/Maildir/new/1455998997.M81437P17339Q63.exolobe1
blob: 1e0218c47e26f796bd4df7a73d9a54ead5ebf7cc (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
Return-Path: <obnam-dev-bounces@obnam.org>
X-Original-To: distix@pieni.net
Delivered-To: distix@pieni.net
Received: from bagpuss.pepperfish.net (bagpuss.pepperfish.net [148.251.8.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pieni.net (Postfix) with ESMTPS id 02F992C147
	for <distix@pieni.net>; Sat, 31 Oct 2015 13:03:03 +0100 (CET)
Received: from platypus.pepperfish.net (unknown [10.112.100.20])
	by bagpuss.pepperfish.net (Postfix) with ESMTP id 770ED2D8;
	Sat, 31 Oct 2015 12:03:02 +0000 (GMT)
Received: from ip6-localhost ([::1] helo=platypus.pepperfish.net)
	by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
	id 1ZsUsA-0006re-9N; Sat, 31 Oct 2015 12:03:02 +0000
Received: from inmail0 ([10.112.100.10] helo=mx0.pepperfish.net)
 by platypus.pepperfish.net with esmtp (Exim 4.80 #2 (Debian))
 id 1ZsUs8-0006qp-DW
 for <obnam-dev@obnam.org>; Sat, 31 Oct 2015 12:03:00 +0000
Received: from mailout.easymail.ca ([64.68.201.169])
 by mx0.pepperfish.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <hsivonen@hsivonen.fi>)
 id 1ZsUs5-00008z-Bt
 for obnam-dev@obnam.org; Sat, 31 Oct 2015 12:03:00 +0000
Received: from localhost (localhost [127.0.0.1])
 by mailout.easymail.ca (Postfix) with ESMTP id 5FFBFE5DD
 for <obnam-dev@obnam.org>; Sat, 31 Oct 2015 08:02:46 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca
X-Spam-Flag: NO
X-Spam-Score: -3.674
X-Spam-Level: 
X-Spam-Status: No, score=-3.674 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.033, 
 BAYES_00=-2.599, DNS_FROM_AHBL_RHSBL=0.692]
Received: from mailout.easymail.ca ([127.0.0.1])
 by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new,
 port 10024) with ESMTP id PZxILDdfJibk for <obnam-dev@obnam.org>;
 Sat, 31 Oct 2015 08:02:45 -0400 (EDT)
Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com
 [209.85.213.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mailout.easymail.ca (Postfix) with ESMTPSA id 096C1E59E
 for <obnam-dev@obnam.org>; Sat, 31 Oct 2015 08:02:45 -0400 (EDT)
Received: by igdg1 with SMTP id g1so28995013igd.1
 for <obnam-dev@obnam.org>; Sat, 31 Oct 2015 05:02:44 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.50.7.70 with SMTP id h6mr2617873iga.63.1446292964734; Sat,
 31 Oct 2015 05:02:44 -0700 (PDT)
Received: by 10.107.19.137 with HTTP; Sat, 31 Oct 2015 05:02:44 -0700 (PDT)
In-Reply-To: <20151019191152.GJ2563@exolobe1.liw.fi>
References: <CAJQvAudeWCMhMvExSSP3whzC4TAnkeOqNU5gNSdYyGxEM9bcnQ@mail.gmail.com>
 <20151019191152.GJ2563@exolobe1.liw.fi>
Date: Sat, 31 Oct 2015 14:02:44 +0200
Message-ID: <CAJQvAud5pODJr+TXRz39Ba0KV8iDqhExrzF8uvCcxhTT3WJgJw@mail.gmail.com>
From: Henri Sivonen <hsivonen@hsivonen.fi>
To: Lars Wirzenius <liw@liw.fi>
Content-Type: text/plain; charset=UTF-8
X-Spam-Score: -2.1
X-Spam-Score-int: -20
X-Spam-Bar: --
X-Scanned-By: pepperfish.net, Sat, 31 Oct 2015 12:03:00 +0000
X-Spam-Report: Content analysis details: (-2.1 points)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.5 PPF_RECEIVED_HTTP      Received header mentions http
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at http://www.dnswl.org/, low
 trust [64.68.201.169 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-ACL-Warn: message may be spam
X-Scan-Signature: e606bea56426b7460dd1a96e279d41e5
Cc: obnam-dev@obnam.org
Subject: Re: Unlocking the repo from the VFS layer
X-BeenThere: obnam-dev@obnam.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Obnam development discussions <obnam-dev-obnam.org>
List-Unsubscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
 <mailto:obnam-dev-request@obnam.org?subject=unsubscribe>
List-Archive: <http://listmaster.pepperfish.net/pipermail/obnam-dev-obnam.org>
List-Post: <mailto:obnam-dev@obnam.org>
List-Help: <mailto:obnam-dev-request@obnam.org?subject=help>
List-Subscribe: <http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org>,
 <mailto:obnam-dev-request@obnam.org?subject=subscribe>
Sender: obnam-dev-bounces@obnam.org
Errors-To: obnam-dev-bounces@obnam.org

On Mon, Oct 19, 2015 at 10:11 PM, Lars Wirzenius <liw@liw.fi> wrote:
> On Sun, Sep 27, 2015 at 03:35:05PM +0300, Henri Sivonen wrote:
>> To address this, I'm trying to patch obnam to automatically reconnect
>> when the SFTP layer raises an exception.
>
> I don't think that logic belongs in the VFS layer, or in the SFTP
> module. It's the kind of policy decision that an upper layer should
> handle. Sorry.

Can you give a more specific hint of which layer I should be looking at?

My thinking with putting the recovery on the VFS layer on the level of
principle is similar to how TCP makes IP seem reliable instead of
making the application worry about failures and on the practical level
it seemed harder to track down all higher-layer call sites that might
experience an exception than to mechanically wrap all methods on the
VFS layer.

-- 
Henri Sivonen
hsivonen@hsivonen.fi
https://hsivonen.fi/

_______________________________________________
obnam-dev mailing list
obnam-dev@obnam.org
http://listmaster.pepperfish.net/cgi-bin/mailman/listinfo/obnam-dev-obnam.org